fix(api): Make type ignores more specific where possible

igorp-collabora · JohnVillalovos · commit e3cb806dc368 · 2025-01-15T08:17:44.000-08:00
Instead of using absolute ignore `# type: ignore` use a more
specific ignores like `# type: ignore[override]`. This might help
in the future where a new bug might be introduced and get ignored
by a general ignore comment but not a more specific one.

Signed-off-by: Igor Ponomarev &lt;igor.ponomarev@collabora.com&gt;
diff --git a/gitlab/v4/objects/files.py b/gitlab/v4/objects/files.py
@@ -51,7 +51,7 @@ def decode(self) -> bytes:
 
     # NOTE(jlvillal): Signature doesn't match SaveMixin.save() so ignore
     # type error
-    def save(  # type: ignore
+    def save(  # type: ignore[override]
         self, branch: str, commit_message: str, **kwargs: Any
     ) -> None:
         """Save the changes made to the file to the server.
@@ -75,7 +75,7 @@ def save(  # type: ignore
     @exc.on_http_error(exc.GitlabDeleteError)
     # NOTE(jlvillal): Signature doesn't match DeleteMixin.delete() so ignore
     # type error
-    def delete(  # type: ignore
+    def delete(  # type: ignore[override]
         self, branch: str, commit_message: str, **kwargs: Any
     ) -> None:
         """Delete the file from the server.
@@ -219,7 +219,7 @@ def create(
     @exc.on_http_error(exc.GitlabUpdateError)
     # NOTE(jlvillal): Signature doesn't match UpdateMixin.update() so ignore
     # type error
-    def update(  # type: ignore
+    def update(  # type: ignore[override]
         self, file_path: str, new_data: Optional[Dict[str, Any]] = None, **kwargs: Any
     ) -> Dict[str, Any]:
         """Update an object on the server.
@@ -254,7 +254,7 @@ def update(  # type: ignore
     @exc.on_http_error(exc.GitlabDeleteError)
     # NOTE(jlvillal): Signature doesn't match DeleteMixin.delete() so ignore
     # type error
-    def delete(  # type: ignore
+    def delete(  # type: ignore[override]
         self, file_path: str, branch: str, commit_message: str, **kwargs: Any
     ) -> None:
         """Delete a file on the server.
diff --git a/gitlab/v4/objects/issues.py b/gitlab/v4/objects/issues.py
@@ -302,7 +302,7 @@ class ProjectIssueLinkManager(ListMixin, CreateMixin, DeleteMixin, RESTManager):
     @exc.on_http_error(exc.GitlabCreateError)
     # NOTE(jlvillal): Signature doesn't match CreateMixin.create() so ignore
     # type error
-    def create(  # type: ignore
+    def create(  # type: ignore[override]
         self, data: Dict[str, Any], **kwargs: Any
     ) -> Tuple[RESTObject, RESTObject]:
         """Create a new object.
diff --git a/gitlab/v4/objects/labels.py b/gitlab/v4/objects/labels.py
@@ -66,7 +66,7 @@ def get(self, id: Union[str, int], lazy: bool = False, **kwargs: Any) -> GroupLa
     # Update without ID.
     # NOTE(jlvillal): Signature doesn't match UpdateMixin.update() so ignore
     # type error
-    def update(  # type: ignore
+    def update(  # type: ignore[override]
         self,
         name: Optional[str],
         new_data: Optional[Dict[str, Any]] = None,
@@ -132,7 +132,7 @@ def get(
     # Update without ID.
     # NOTE(jlvillal): Signature doesn't match UpdateMixin.update() so ignore
     # type error
-    def update(  # type: ignore
+    def update(  # type: ignore[override]
         self,
         name: Optional[str],
         new_data: Optional[Dict[str, Any]] = None,
