Merge pull request #1415 from JohnVillalovos/jlvillal/list_attribute_int

nejch · web-flow · commit dde01c70c2bb · 2021-04-27T00:40:35.000+02:00
feat: add support for lists of integers to ListAttribute
diff --git a/gitlab/tests/test_types.py b/gitlab/tests/test_types.py
@@ -59,6 +59,11 @@ def test_list_attribute_get_for_api_from_list():
     assert o.get_for_api() == "foo,bar,baz"
 
 
+def test_list_attribute_get_for_api_from_int_list():
+    o = types.ListAttribute([1, 9, 7])
+    assert o.get_for_api() == "1,9,7"
+
+
 def test_list_attribute_does_not_split_string():
     o = types.ListAttribute("foo")
     assert o.get_for_api() == "foo"
diff --git a/gitlab/types.py b/gitlab/types.py
@@ -42,7 +42,7 @@ def get_for_api(self):
         if isinstance(self._value, str):
             return self._value
 
-        return ",".join(self._value)
+        return ",".join([str(x) for x in self._value])
 
 
 class LowercaseStringAttribute(GitlabAttribute):
