Merge pull request #2221 from python-gitlab/jlvillal/unparse

nejch · web-flow · commit 9e0b60fb36c6 · 2022-08-04T18:06:38.000+02:00
chore: use `urlunparse` instead of string replace
diff --git a/gitlab/client.py b/gitlab/client.py
@@ -685,7 +685,7 @@ def http_request(
         params = parse.parse_qs(parsed.query)
         utils.copy_dict(src=query_data, dest=params)
 
-        url = raw_url.replace(parsed.query, "").strip("?")
+        url = parse.urlunparse(parsed._replace(query=""))
 
         # Deal with kwargs: by default a user uses kwargs to send data to the
         # gitlab server, but this generates problems (python keyword conflicts
