Oops, Generic.__eq__ was too generous.

Guido van Rossum · Guido van Rossum · commit 81fdd0b78cb0 · 2015-01-07T19:31:11.000-08:00
diff --git a/prototyping/test_typing.py b/prototyping/test_typing.py
@@ -610,6 +610,24 @@ class Y(C[int]):
         assert Y.__qualname__ == 'GenericTests.test_repr_2.<locals>.Y'
         assert repr(Y).split('.')[-1] == 'Y[int]'
 
+    def test_eq_1(self):
+        assert Generic == Generic
+        assert Generic[T] == Generic[T]
+        assert Generic[KT] != Generic[VT]
+
+    def test_eq_2(self):
+
+        class A(Generic[T]):
+            pass
+
+        class B(Generic[T]):
+            pass
+
+        assert A == A
+        assert A != B
+        assert A[T] == A[T]
+        assert A[T] != B[T]
+
 
 class UndefinedTest(TestCase):
 
diff --git a/prototyping/typing.py b/prototyping/typing.py
@@ -715,10 +715,11 @@ def __repr__(self):
     def __eq__(self, other):
         if not isinstance(other, GenericMeta):
             return NotImplemented
-        return other.__parameters__ == self.__parameters__
+        return (self.__name__ == other.__name__ and
+                self.__parameters__ == other.__parameters__)
 
     def __hash__(self):
-        return hash(self.__parameters__)
+        return hash((self.__name__, self.__parameters__))
 
     def __getitem__(self, params):
         if not isinstance(params, tuple):
