improve urlencode(...) annotation for quote_via #6345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
reviewed
Nov 22, 2021
| encoding: str = ..., | ||
| errors: str = ..., | ||
| quote_via: Callable[[str, AnyStr, str, str], str] = ..., | ||
| quote_via: Callable[[AnyStr, _Str, str, str], str] = ..., |
There was a problem hiding this comment.
AnyStr has no meaning here, as there is only one instance. Depending on the exact composition of query, quote_via() is called with two or four arguments. If it's called with four arguments, the first argument is a str. I believe that using str is fine, until we improve quote_via to also accept a two argument form.
There was a problem hiding this comment.
it does have some meaning as without it the overloaded function doesn't match the Callable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6009
I opted to change
safeto_Str(which isstr | bytes) since that more closely matches the default parameter. forquote_viaI changed the first parameter toAnyStrto match the overloadedquote_*functions