Make FileIO compatible

python · srittau · Feb 14, 2024 · Feb 14, 2024 · Feb 14, 2024 · Feb 14, 2024
commit ad8461f2b51f95efe5a3a2c125d707bb89a18e6c
diff --git a/stdlib/io.pyi b/stdlib/io.pyi
@@ -94,7 +94,10 @@ class BufferedIOBase(IOBase):
 
 class FileIO(RawIOBase, BinaryIO):  # type: ignore[misc]  # incompatible definitions of writelines in the base classes
     mode: str
-    name: FileDescriptorOrPath
+    # The type of "name" equals the argument passed in to the constructor,
+    # but that can make FileIO incompatible with other I/O types that assume
+    # "name" is a str. In the future, making FileIO generic might help.
+    name: Any
     def __init__(
         self, file: FileDescriptorOrPath, mode: str = ..., closefd: bool = ..., opener: _Opener | None = ...
     ) -> None: ...

diff --git a/test_cases/stdlib/check_io.py b/test_cases/stdlib/check_io.py
@@ -1,4 +1,6 @@
 from gzip import GzipFile
-from io import TextIOWrapper
+from io import FileIO, TextIOWrapper
 
+TextIOWrapper(FileIO(""))
+TextIOWrapper(FileIO(13))
 TextIOWrapper(GzipFile(""))