8000 stub for asyncio.coroutine incorrect · Issue #89 · python/typeshed · GitHub
[go: up one dir, main page]
Skip to content

stub for asyncio.coroutine incorrect #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ddfisher opened this issue Feb 24, 2016 · 5 comments
Closed

stub for asyncio.coroutine incorrect #89

ddfisher opened this issue Feb 24, 2016 · 5 comments
Assignees
@ddfisher

Comments

@ddfisher
Copy link
Contributor

In PR #81, an incorrect stub was introduced for coroutine (see here) which breaks this mypy unit test, among others. I'm not sure why this wasn't caught by CI.

A fix for this is blocking python/mypy#1218, which needs to update to the latest typeshed master.
@gvanrossum
Copy link
Member

Can you investigate why typeshed's CI didn't catch this? Also go ahead and fix it in typeshed.

@gvanrossum
Copy link
Member

FWIW typeshed's CI doesn't run mypy's unit tests. It just runs mypy over the code in typeshed.

@ddfisher
Copy link
Contributor Author

Oh okay. That would be why it wasn't caught by CI, then.

@gvanrossum
Copy link
Member

It would be caught by mypy's CI on the diff that synced up to the new typeshed version though... But I haven't made that diff yet (and now I won't until I've verified everything properly).

@ddfisher ddfisher mentioned this issue Feb 24, 2016
Merged
@ddfisher
Copy link
Contributor Author

Right. That's exactly how I caught it, actually.

@gvanrossum gvanrossum mentioned this issue Feb 24, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddfisher ddfisher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ddfisher @gvanrossum
0