Use correct block, enable built-in slash keypress #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CSS in the base template was updated to include this directive in #7695 and released in sphinx v3.1.0. The original implementation was in python#46, prior to the basic theme including it, and now we have the same meta tag duplicated. Remove the block, and reduce the duplication. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
When the template was made responsive, the choice was made to override the `body_tag` fragment. The `body_tag` block is a literal `<body>` which allows the theme developer to set properties on the `body` tag. See: sphinx-doc/sphinx#4140 Instead, use the `document` block as documented. https://www.sphinx-doc.org/en/master/development/templating.html#blocks Overriding the correct block places the `mobile-nav` section _after_ the majority of the other HTML parts, which enables the correct function of the `/` keyboard shortcut. Resolves python#130 Closes python#131 Closes python#135 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Closed
|
@hugovk I think this one is the thing we want! |
|
Thanks! Preview: https://python-docs-theme-previews--141.org.readthedocs.build/en/141/ With this, slash highlights the search box in the top right in desktop view: 
But not the one in mobile view: 
Which is the more useful way around. |
hugovk
approved these changes
Jul 27, 2023
This was referenced Aug 5, 2023
Closed
This was referenced Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because
2F62
no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a commit removing a duplicate block.
When the template was made responsive, the choice was made to override
the
body_tagfragment.The
body_tagblock is a literal<body>which allows the theme developerto set properties on the
bodytag.See: sphinx-doc/sphinx#4140
Instead, use the
documentblock as documented.https://www.sphinx-doc.org/en/master/development/templating.html#blocks
Overriding the correct block places the
mobile-navsection after themajority of the other HTML parts, which enables the correct function of
the
/keyboard shortcut.Resolves #130
Closes #131
Closes #135