8000 Avoid italics and use monospace for function prototypes · Issue #42 · python/python-docs-theme · GitHub
[go: up one dir, main page]
Skip to content
8000

Avoid italics and use monospace for function prototypes #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JulienPalard opened this issue Jan 22, 2020 · 7 comments
Closed

Avoid italics and use monospace for function prototypes #42

JulienPalard opened this issue Jan 22, 2020 · 7 comments

Comments

@JulienPalard
Copy link
Member

See https://bugs.python.org/issue38495
@shivankgtm
Copy link

This issue seems to be with docs of python3.7 only. can I take this issue to solve?

@JulienPalard
Copy link
Member Author

The fact that it only affects 3.7 made me search why. Looks like it has been done in 10be089, so now we "just" need to understand why it's not applied in 3.7.

Feel free to take a look at it, but maybe as the python-docs-theme is not pinned in docsbuild scripts nor in cpython, it just never updated, I'll probably have to check it myself on the server, hope I'll have time soon.

@pradyunsg
Copy link
Member

Uhhhhh. I'm not a huge fan of the patch from #25 -- the specific styling for this element comes from the pygments theme, which means that the fix is a bit of a bodge.

That said, I don't see the issue in 3.7's docs anymore and this can be closed IMO.

@JulienPalard
Copy link
Member Author

I still see it in 3.7 where it looks like an empty string:

Screenshot_2020-11-15 Built-in Functions — Python 3 7 9 documentation

vs 3.8 were I clearly see it's a space:
Screenshot_2020-11-15 Built-in Functions — Python 3 8 6 documentation

@JulienPalard
Copy link
Member Author
JulienPalard commented Nov 15, 2020 •
edited
Loading

python-docs-theme is not pinned, so the venv on the build server is probably just old, I'll check this.

Looks like all venvs use python-docs-theme==2020.1, I'll check styles in production to try to pinpoint the difference.

@JulienPalard
Copy link
Member Author

Oh, answer is simple, python-docs-theme was not separated in 3.7. And 3.7 is in security only, better keep things untouched. Bug is fixed for >=3.8, which is good enough.

@pradyunsg
Copy link
Member

Awesome! Thanks for looking @JulienPalard! ^.^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JulienPalard @pradyunsg @shivankgtm
0