Apply suggestions from code review

hugovk · web-flow · commit b52b8cf68741 · 2023-02-07T00:44:34.000+02:00
diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst
@@ -14,11 +14,11 @@
 - Commit this last bump.
 - push and push the tag (``git push && git push --tags``)
 
-# Makefile Usage
+# Makefile usage
 
 This project includes a simple Makefile for syncing changes to the theme with
-the main cpython repository. Run ``make help`` for details on available rules.
+the main CPython repository. Run ``make help`` for details on available rules.
 
 There is one configurable variable, ``CPYTHON_PATH``, which should be the path
-to the cpython repository on your machine. By default, it points to
+to the CPython repository on your machine. By default, it points to
 ``../cpython``.
diff --git a/Makefile b/Makefile
@@ -2,20 +2,21 @@ CPYTHON_PATH               = ../cpython
 PACKAGE_ABS_PATH = $(shell pwd)/$(shell find dist/python-docs-theme-*.tar.gz)
 
 
-.PHONY: all
-all: install
+.PHONY: html
+html: venv
 	cd $(CPYTHON_PATH)/Doc && \
 		make html
 
 
-.PHONY: install
-install:
+.PHONY: venv
+venv:
 	python3 -m build
-	cd $(CPYTHON_PATH)/Doc && \
-		./venv/bin/pip install $(PACKAGE_ABS_PATH)
+	cd $(CPYTHON_PATH)/Doc \
+		&& make venv \
+		&& ./venv/bin/pip install $(PACKAGE_ABS_PATH)
 
 .PHONY: help
 help:
-	@echo "all:		default rule; run the \`install\` rule, and also rebuild the cpython docs"
-	@echo "install: 	build the package, and install it into the virtual environment"
+	@echo "html:		default rule; run the \`venv\` rule, and also rebuild the CPython docs"
+	@echo "venv: 		build the package, and install it into the virtual environment"
 	@echo "		at $(CPYTHON_PATH)/Doc/venv"
