Update scripts/complete_index.py

cacrespo · cacrespo · commit f3f4dc64b635 · 2023-11-27T18:17:53.000-03:00
Apply suggestions from @rtobar
diff --git a/scripts/complete_index.py b/scripts/complete_index.py
@@ -22,16 +22,14 @@ def out_of_order_entries(po_file):
     Compare the order of source lines against the order in which they appear in
     the file, and return a generator with entries that are out of order.
     """
-    po_file = polib.pofile(po_file)
     po_entries = [entry for entry in po_file if not entry.obsolete]
     val_max = 0
 
     for entry in po_entries:
         source_index = int(entry.occurrences[0][1])
 
         if source_index <= val_max:
-            yield(entry)
-            po_file.save()
+            yield entry
 
         val_max = max(val_max, source_index)
 
@@ -50,22 +48,26 @@ def complete_index(po_files=None):
     if not po_files:
         po_files = Path(".").glob("**/*.po")
 
-    for po_file in po_files:
+    for po_file_path in po_files:
+
         try:
+            po_file = polib.pofile(po_file_path)
+
             # Ask to complete entries out of order with original text
             for entry in out_of_order_entries(po_file):
                 user_input = input(f"\n{entry}\nIs this a index entry? (y/N):")
                 if user_input.lower() == "y":
                     entry.msgstr = entry.msgid
+                    po_file.save() # Save if an entry has been modified
 
         except KeyboardInterrupt:
             break
 
         except Exception as e:
-            print(f"Error! file {po_file}: {e}\n")
+            print(f"Error! file {po_file_path}: {e}\n")
 
         else:
-            print(f"{po_file} processed!\n")
+            print(f"\n---\n{po_file_path} processed!\n---")
 
 
 if __name__ == "__main__":
