10000 support non-ascii chars in hgrev by ewdurbin · Pull Request #582 · python/psf-salt · GitHub
[go: up one dir, main page]

Skip to content

support non-ascii chars in hgrev #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2025
Merged

support non-ascii chars in hgrev #582

merged 2 commits into from
May 31, 2025

Conversation

ewdurbin
Copy link
Member

text=True was trying to encode the output as ascii, which breaks notably on committer names with diacritics.

Let the utf-8 flow!
@ewdurbin ewdurbin requested a review from JacobCoffee as a code owner May 31, 2025 14:33
@ewdurbin ewdurbin merged commit 7bb3480 into main May 31, 2025
2 checks passed
@ewdurbin ewdurbin deleted the hgrev-non-ascii branch May 31, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0