8000 Reduce the contrast in the banding of tables · Issue #2749 · python/peps · GitHub
[go: up one dir, main page]
Skip to content

Reduce the contrast in the banding of tables #2749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pradyunsg opened this issue Aug 5, 2022 · 8 comments · Fixed by #2805
Closed

Reduce the contrast in the banding of tables #2749

pradyunsg opened this issue Aug 5, 2022 · 8 comments · Fixed by #2805
Labels
meta Related to the repo itself and its processes

Comments

@pradyunsg
Copy link
Member

Currently, the constrast difference between the banding for rows in a table is somewhat drastic, making it seem like the alternating rows have some sort of emphasis being applied on them. We should probably avoid that, since that's not the intent with this banding.

Screenshot 2022-08-05 at 19 13 57

Screenshot 2022-08-05 at 19 13 47
@pradyunsg pradyunsg added the meta Related to the repo itself and its processes label Aug 5, 2022
@pradyunsg
Copy link
Member Author
pradyunsg commented Aug 5, 2022 •
edited
Loading

Taking a few minutes to think about this, the approaches I can come up with are:

And... that's the order of preference I have for them as well (i.e. reducing the contrast being my personally preferred option).

@hugovk
Copy link
Member
hugovk commented Aug 5, 2022

Please see PRs #2740 and #2734 :)

@CAM-Gerlach
Copy link
Member

And to summarize, this was inadvertently changed because of #2691

Reduce the contrast. :)

is #2740 (which basically restores the status quo), and

Remove the banding [...] in favor of light border between twos [I assume this is a typo for rows]

is #2734 (which does exactly that)

@pradyunsg
Copy link
Member Author

Can we land one of those, and move forward on this?

@merwok
Copy link
Member
merwok commented Aug 26, 2022 •
edited
Loading

The two PRs got comments from a few people, without clear consensus in my opinion.
I hate to say this, but I think you may need to start a discussion about PEP table styling on discourse.

Alternatively, a confident core dev could decide that if main docs don’t have stripes, PEPs don’t need stripes, and go merge that PR.

@pradyunsg
Copy link
Member Author
pradyunsg commented Aug 26, 2022 •
edited
Loading

I don't think tweaking colors to be better, should need a discourse discussion -- #2740 (comment).

Zebra stripes vs borders etc is a discussion I'm not interested in personally, so I won't be poking that forward -- IMO changing the complete presentation style of tables should not be a blocker to improving colors to make them more readable.

@AA-Turner
Copy link
Member

I originally went with striping as it was used on the old /dev/peps site--count me amongst the supporters of #2734. We can look to merge #2740 in the near-term though as a straight improvement over the status quo.

A

@CAM-Gerlach
Copy link
Member

Alternatively, a confident core dev could decide that if main docs don’t have stripes, PEPs don’t need stripes, and go merge that PR.

IMO, I'm not sure it would be entirely appropriate for another Python core dev to to swoop in and take unilateral action on an meta issue like that amidst ongoing discussion amongst the maintainers of this repository, as opposed to offering their opinion, suggestions and seeking to build consensus, which would of course be much appreciated.

We can look to merge #2740 in the near-term though as a straight improvement over the status quo.

Seems 👍 to me, I don't think anyone disagrees the current colors are too strong; #2740 effectively reverts to the status quo before the regression introduced in #2691 which made them that way, and the status quo wins in a stalemate (for now). To be clear, I'm not against #2734 , if that's where the consensus leads, but it is a bigger change that may need some further discussion, iteration and refinement, which suggests we should just fix the regression first and then have discussion rather than blocking on it.

@CAM-Gerlach CAM-Gerlach mentioned this issue Sep 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta Related to the repo itself and its processes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Style: Fix zebra stripes and improve table & code presentation CAM-Gerlach/peps
5 participants
@merwok @hugovk @pradyunsg @AA-Turner @CAM-Gerlach
0