8000 Generate an error if trying to use @final with TypedDict by TH3CHARLie · Pull Request #7865 · python/mypy · GitHub
[go: up one dir, main page]
Skip to content

Generate an error if trying to use @final with TypedDict #7865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 4, 2019
Merged

Generate an error if trying to use @final with TypedDict #7865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
07be66c
generate an error if trying to use @final with TypedDict
TH3CHARLie Nov 4, 2019
958d998
adjust indentation, add RefExpr check
TH3CHARLie Nov 4, 2019
a6bd4ae
Update spacing in mypy/semanal.py
TH3CHARLie Nov 4, 2019
4666274
add test case: testCannotUseFinalDecoratorWithTypedDict
TH3CHARLie Nov 4, 2019
1fcb297
Add newline at end of test file
TH3CHARLie Nov 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions mypy/semanal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1067,6 +1067,12 @@ def analyze_class(self, defn: ClassDef) -> None:

is_typeddict, info = self.typed_dict_analyzer.analyze_typeddict_classdef(defn)
if is_typeddict:
for decorator in defn.decorators:
decorator.accept(self)
if isinstance(decorator, RefExpr):
if decorator.fullname in ('typing.final',
'typing_extensions.final'):
self.fail("@final cannot be used with TypedDict", decorator)
if info is None:
self.mark_incomplete(defn.name, defn)
else:
Expand Down
13 changes: 13 additions & 0 deletions test-data/unit/check-typeddict.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1924,3 +1924,16 @@ v = {bad2: 2} # E: Extra key 'bad' for TypedDict "Value"

[builtins fixtures/dict.pyi]
[typing fixtures/typing-full.pyi]

[case testCannotUseFinalDecoratorWithTypedDict]
from typing import TypedDict
from typing_extensions import final

@final # E: @final cannot be used with TypedDict
class DummyTypedDict(TypedDict):
int_val: int
float_val: float
str_val: str

[builtins fixtures/dict.pyi]
[typing fixtures/typing-full.pyi]
0