Implementation for validation checks on functions that can only be called on dataclasses #14286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…taclass instances
|
Thanks for the PR! Unfortunately it looks like we've already had a PR filed to fix this issue (#14263) It's always best to check that before you start work on a PR -- you can see linked PRs in the "Development" tab on the right-hand side when you're looking at a GitHub issue (assuming you're on a desktop). The other PR looks more complete (it also deals with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14215
Description:
As mentioned in the issue, methods such as replace() and field() should only be called on dataclass instances. In this implementation, I added a callback to detect such issues.
Testing:
I did not edit the test file in this commit - one of my teammates will in the near future.
For local testing, when I tested my implementation against
I got the output of:
When I tested my implementation against
I got this output, as desired:
