Fix functional API tests to be endian-agnostic #313
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the "backslashreplace" tests for the functional API to be
endian-agnostic. The tests used to rely on `.encode("utf-16")`
producing the same data as found in the test file. However, on big
endian platforms it would produce a big endian encoding, while the test
file is little endian. To avoid the problem, explicitly specify
`utf-16-le` encoding. Since this meant that the BOM is no longer
produced, explicitly include it in input.
Fixes python#312
|
Thanks for the contrib, and sorry I didn't see it sooner. This was superseded by 8c274e5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the "backslashreplace" tests for the functional API to be endian-agnostic. The tests used to rely on
.encode("utf-16")producing the same data as found in the test file. However, on big endian platforms it would produce a big endian encoding, while the test file is little endian. To avoid the problem, explicitly specifyutf-16-leencoding. Since this meant that the BOM is no longer produced, explicitly include it in input.Fixes #312