meta: add SimplePath protocol for PathDistribution #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5f23a8a to
d0616a8
Compare
This is needed to properly annotate code that uses PathDistribution, otherwise I need to keep redefining the protocol in my code. Signed-off-by: Filipe Laíns <lains@riseup.net>
d0616a8 to
fa20a0a
Compare
Signed-off-by: Filipe Laíns <lains@riseup.net>
… to easily distinguish. Add changelog.
Member
Author
|
Please ping me when this goes to CPython, so that I can send a PR to typeshed. |
Member
|
I don't understand the diffcov failure. It says: It indicates that line 26 is not covered and line 786 is not covered. But those lines should be executed on import. |
Member
|
I just ignored the spurious diffcov failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to properly annotate code that uses PathDistribution,
otherwise I need to keep redefining the protocol in my code.
Signed-off-by: Filipe Laíns lains@riseup.net