8000 Recommend GitHub CLI for easier bootstrapping by jaraco · Pull Request #946 · python/devguide · GitHub
[go: up one dir, main page]

Skip to content

Recommend GitHub CLI for easier bootstrapping #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your acc 8000 ount

Closed
wants to merge 1 commit into from

Conversation

jaraco
Copy link
Member
@jaraco jaraco commented Sep 5, 2022

As I was working on #943, I realized it might be easier to direct users to use the GitHub CLI instead of all of the manual steps.

Thoughts?

  • Consider directing users to the GitHub CLI for easier bootstrapping.

@jaraco jaraco changed the base branch from main to bugfix/upstream-main September 5, 2022 17:11
Copy link
Member
@ezio-melotti ezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think gh should be required. It's fine documenting it as an alternative setup (here or in the bootcamp), but a regular setup that doesn't use gh should still be documented.

See also:

@erlend-aasland
Copy link
Contributor

I think promoting gh is a good thing. It is a great tool for our workflow.

@hugovk
Copy link
Member
hugovk commented Sep 6, 2022

Sphinx Inline Tabs could be useful to show the two different options.

It's used on https://packaging.python.org/en/latest/tutorials/packaging-projects/ to select between Unix/macOS and Windows (and also Hatchling, setuptools, Flit and PDM):

It's nice that you when you select one tab, it flips for the whole page:

image

image

Also used for example at https://pip.pypa.io/en/stable/getting-started/

@CAM-Gerlach
Copy link
Member

Agreed that showing both options, one with a specific one wrapper tool and the more manual one with the "standard" tooling, would be helpful (I personally still use hub myself). And +1 for Sphinx inline tabs; with appropriate organization they allow showing alternatives while avoiding making the document longer and more confusing. We (Spyder) really need to adopt this ourselves in all our own docs that offer both venv/pip and conda environment and installation methods.

@hugovk is there a built-in way to link the tab choices, so that clicking on one will automatically switch all of them, or is that a custom extension on the packaging site? That definitely is a big boon for usability.

@hugovk
Copy link
Member
hugovk commented Sep 12, 2022

@CAM-Gerlach Yes, it's built-in!

  • Synchronisation: Tabs with the same label all switch with a single click.
  • Works without JavaScript: JavaScript is not required for the basics, only for synchronisation.

And see the demo at https://sphinx-inline-tabs.readthedocs.io/en/latest/

@ezio-melotti
Copy link
Member

@jaraco, do you want to update the PR to use sphinx-inline-tabs?

@jaraco
Copy link
Member Author
jaraco commented Oct 7, 2022

While I can see the value in using sphinx-inline-tabs, I worry that the maintenance burden is getting out of hand, especially considering that the docs exist in two places, so anything that happens probably needs to be duplicated, so duplicating the techniques would be a multiplier on the existing multiple. It's probably best to provide one technique. I wouldn't be opposed to someone adopting this diff to use sphinx-inline-tabs, but I'm not inclined to do it myself.

@jaraco jaraco closed this Oct 7, 2022
@jaraco jaraco deleted the feature/gh branch October 7, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0