8000 Typo and grammar fixes to documenting.rst "Translating" section by bgrant · Pull Request #698 · python/devguide · GitHub
[go: up one dir, main page]
Skip to content

8000 Typo and grammar fixes to documenting.rst "Translating" section #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 3, 2022
Merged

Typo and grammar fixes to documenting.rst "Translating" section #698

merged 4 commits into from
Mar 3, 2022

Conversation

bgrant
Copy link
Contributor
@bgrant bgrant commented May 17, 2021

This consists only of minor typo fixes and grammar suggestions for the Translating section of documenting.rst. Please let me know if you would like an issue made.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@bgrant

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@hugovk
Copy link
Member
hugovk commented Jan 7, 2022

@bgrant Looks good, would you like to resolve the conflicts?

@bgrant
Copy link
Contributor Author
bgrant commented Jan 7, 2022

Done! Thanks for your review!

@bgrant
Copy link
Contributor Author
bgrant commented Mar 3, 2022

Fixed more conflicts. Anything else I need to do to get this merged? Thanks.

JelleZijlstra
JelleZijlstra reviewed Mar 3, 2022
View reviewed changes
Copy link
Member
@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I can merge this.

8000
@bgrant @JelleZijlstra
Update documenting.rst
20c8b55 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@JelleZijlstra JelleZijlstra merged commit e14302a into python:main Mar 3, 2022
@bgrant bgrant deleted the chore/proofread-translating branch March 3, 2022 21:55
AA-Turner pushed a commit to AA-Turner/devguide that referenced this pull request Jun 17, 2022
@bgrant
Typo and grammar fixes to documenting.rst "Translating" section (pyth…
fd44d6b 
…on#698)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@the-knights-who-say-ni @hugovk @JelleZijlstra
0