8000 Add guidelines for triagers closing PRs (#530) · python/devguide@a175ef0 · GitHub
[go: up one dir, main page]

Skip to content

Commit a175ef0

Browse files
aerosbrettcannon
authored andcommitted
Add guidelines for triagers closing PRs (#530)
1 parent 2405391 commit a175ef0

File tree

1 file changed

+14
-3
lines changed

1 file changed

+14
-3
lines changed

triaging.rst

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ Responsibilities include 8000 :
2828
* PR/issue management
2929
- Renaming PRs
3030
- Reviewing PRs
31-
- Closing PRs and issues
3231
- Assisting contributors
3332
- Notifying appropriate core developers
3433
* Applying appropriate labels to PRs/Issues
@@ -37,6 +36,16 @@ Responsibilities include:
3736
- Good first issue
3837
- Other categorizations
3938

39+
As triagers gain experience, they may have some intuition of when a PR should
40+
be closed. Triagers can recommend closing a PR, but the final decision must be
41+
made by a core developer. By having triagers and core developers work together,
42+
the author receives a careful consideration of their PR. This encourages future
43+
contributions, regardless of whether their PR is accepted or closed.
44+
45+
Triagers can make use of the ``invalid`` and ``stale`` labels to suggest that a
46+
PR may be suitable for closure. For more information, see the
47+
:ref:`GitHub PR labels <github-pr-labels>` section.
48+
4049
It is also of paramount importance to treat every contributor to the Python
4150
project kindly and with respect. Regardless of whether they're entirely new
4251
or a veteran core developer, they're actively ch 8000 oosing to voluntarily donate their
@@ -72,6 +81,7 @@ For every new triager, it would be great to announce them in the python-committe
7281
mailing list and core-workflow category in Discourse. `Example announcement
7382
<https://discuss.python.org/t/abhilash-raj-has-been-granted-triage-role-on-github/2089>`_.
7483

84+
.. _github-pr-labels:
7585

7686
GitHub Labels for PRs
7787
'''''''''''''''''''''
@@ -93,8 +103,9 @@ expert-asyncio
93103
invalid
94104
Used manually for PRs that do not meet basic requirements and
95105
automatically added by bedevere when PR authors attempt to merge maintenace
96-
branches into the master branch. During competitions, this label causes the
97-
PR to not count towards the author's contributions.
106+
branches into the master branch. During events such as the October
107+
Hacktoberfest, this label will prevent the PR from counting toward the
108+
author's contributions.
98109

99110
needs backport to X.Y
100111
Used for PRs which are appropriate to backport to

0 commit comments

Comments
 (0)
0