8000 Minor corrections to instructions regarding automerge (#1085) · python/devguide@83ab469 · GitHub
[go: up one dir, main page]

Skip to content

Commit 83ab469

Browse files
authored
Minor corrections to instructions regarding automerge (#1085)
1 parent 3978ed3 commit 83ab469

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

getting-started/git-boot-camp.rst

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -465,11 +465,12 @@ You can read more about what to look for before accepting a change
465465
:ref:`here <committing>`.
466466

467467
All pull requests have required checks that need to pass before a change
468-
can be merged. After a change was accepted by at least one core
469-
developer review, you can schedule an automatic merge of the change by
468+
can be merged. At any point, a core developer can schedule an automatic merge
469+
of the change by
470470
clicking the gray ``Enable auto-merge (squash)`` button. You will find
471471
it at the bottom of the pull request page. The auto-merge will only
472-
happen if all the required checks pass.
472+
happen if all the required checks pass, but the PR does not need to have been
473+
approved for a successful auto-merge to take place.
473474

474475
If all required checks are already finished on a PR you're reviewing,
475476
in place of the gray ``Enable auto-merge`` button you will find a green
@@ -516,8 +517,9 @@ recommended approach.
516517
To pause automatic merging, apply the "DO-NOT-MERGE" label to the PR or
517518
submit a review requesting changes. The latter will put an "awaiting
518519
changes" label on the PR, which pauses the auto-merge similarly to
519-
"DO-NOT-MERGE". After the author submits a fix, re-requests review, and
520-
receives a new accepting review, auto-merge will complete.
520+
"DO-NOT-MERGE". After the author submits a fix and re-requests review, you can
521+
resume the auto-merge process either by submitting an approving review or by
522+
dismissing your previous review that requested changes.
521523

522524
Note that pushing new changes after the auto-merge flow was enabled
523525
does **NOT** stop it.

0 commit comments

Comments
 (0)
0