From b51d6183826330689fc9294833f10c285bbb1f8e Mon Sep 17 00:00:00 2001 From: sobolevn Date: Fri, 21 Oct 2022 12:22:28 +0300 Subject: [PATCH 1/2] gh-98500: Fix typing docs for `*View` classes --- Doc/library/typing.rst | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Doc/library/typing.rst b/Doc/library/typing.rst index dc5696aff69bd4..c9f3822151170e 100644 --- a/Doc/library/typing.rst +++ b/Doc/library/typing.rst @@ -2096,7 +2096,7 @@ Corresponding to collections in :mod:`collections.abc` :class:`collections.abc.Container` now supports ``[]``. See :pep:`585` and :ref:`types-genericalias`. -.. class:: ItemsView(MappingView, Generic[KT_co, VT_co]) +.. class:: ItemsView(MappingView, AbstractSet[tuple[KT_co, VT_co]], Generic[KT_co, VT_co]) A generic version of :class:`collections.abc.ItemsView`. @@ -2104,7 +2104,7 @@ Corresponding to collections in :mod:`collections.abc` :class:`collections.abc.ItemsView` now supports ``[]``. See :pep:`585` and :ref:`types-genericalias`. -.. class:: KeysView(MappingView[KT_co], AbstractSet[KT_co]) +.. class:: KeysView(MappingView, AbstractSet[KT_co], Generic[KT_co]) A generic version of :class:`collections.abc.KeysView`. @@ -2124,7 +2124,7 @@ Corresponding to collections in :mod:`collections.abc` :class:`collections.abc.Mapping` now supports ``[]``. See :pep:`585` and :ref:`types-genericalias`. -.. class:: MappingView(Sized, Iterable[T_co]) +.. class:: MappingView(Sized) A generic version of :class:`collections.abc.MappingView`. @@ -2164,7 +2164,7 @@ Corresponding to collections in :mod:`collections.abc` :class:`collections.abc.Sequence` now supports ``[]``. See :pep:`585` and :ref:`types-genericalias`. -.. class:: ValuesView(MappingView[VT_co]) +.. class:: ValuesView(MappingView, Collection[_VT_co], Generic[_VT_co]) A generic version of :class:`collections.abc.ValuesView`. From 29d36866c54f9d0a48efd6a8d1745101450a6879 Mon Sep 17 00:00:00 2001 From: Nikita Sobolev Date: Mon, 24 Oct 2022 13:02:07 +0300 Subject: [PATCH 2/2] Address review --- Doc/library/typing.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Doc/library/typing.rst b/Doc/library/typing.rst index c9f3822151170e..c6f709158cc2f8 100644 --- a/Doc/library/typing.rst +++ b/Doc/library/typing.rst @@ -2096,7 +2096,7 @@ Corresponding to collections in :mod:`collections.abc` :class:`collections.abc.Container` now supports ``[]``. See :pep:`585` and :ref:`types-genericalias`. -.. class:: ItemsView(MappingView, AbstractSet[tuple[KT_co, VT_co]], Generic[KT_co, VT_co]) +.. class:: ItemsView(MappingView, AbstractSet[tuple[KT_co, VT_co]]) A generic version of :class:`collections.abc.ItemsView`. @@ -2104,7 +2104,7 @@ Corresponding to collections in :mod:`collections.abc` :class:`collections.abc.ItemsView` now supports ``[]``. See :pep:`585` and :ref:`types-genericalias`. -.. class:: KeysView(MappingView, AbstractSet[KT_co], Generic[KT_co]) +.. class:: KeysView(MappingView, AbstractSet[KT_co]) A generic version of :class:`collections.abc.KeysView`. @@ -2164,7 +2164,7 @@ Corresponding to collections in :mod:`collections.abc` :class:`collections.abc.Sequence` now supports ``[]``. See :pep:`585` and :ref:`types-genericalias`. -.. class:: ValuesView(MappingView, Collection[_VT_co], Generic[_VT_co]) +.. class:: ValuesView(MappingView, Collection[_VT_co]) A generic version of :class:`collections.abc.ValuesView`.