GH-94262: Don't create frame objects for frames that aren't complete. #94371
Conversation
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 5043a8b 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
|
When you're done making the requested changes, leave the comment: |
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @pablogsal: please review the changes made to this pull request. |
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 939769c 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
|
Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
… complete. (pythonGH-94371) (cherry picked from commit 544531d) Co-authored-by: Mark Shannon <mark@hotpy.org>
|
GH-94482 is a backport of this pull request to the 3.11 branch. |
Since 3.11 we have moved some low level operations to the bytecode which mean that frames can be in a partially constructed state during GC, or other operations that could expose them to Python code (or third party C code).
We already avoid tracing any instructions before the first
RESUMEwhen executing a frame.This PR prevents creating a frame object before the first
RESUMEhas been reached.