10000 gh-74696: Do not change the current working directory in shutil.make_archive() if possible by serhiy-storchaka · Pull Request #93160 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-74696: Do not change the current working directory in shutil.make_archive() if possible #93160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 22, 2022
Merged

gh-74696: Do not change the current working directory in shutil.make_archive() if possible #93160

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d9f680d
gh-74696: Do not change the current working directory in shutil.make_…
serhiy-storchaka May 24, 2022
21cd33d
Add comments for _ARCHIVE_FORMATS and _UNPACK_FORMATS.
serhiy-storchaka May 24, 2022
fb50a41
Update Lib/shutil.py
serhiy-storchaka May 24, 2022
2d497e3
Minor doc tweaks
ambv Jun 21, 2022
1ccb177
Merge branch 'main' into shutil-make_archive-chdir
serhiy-storchaka Jun 22, 2022
927d2d4
Add tests.
serhiy-storchaka Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next 8000 Next commit
Minor doc tweaks
  • Loading branch information
@ambv
ambv committed Jun 21, 2022
commit 2d497e3c13283acd3a1e23233568f1cbc796abc7
8 changes: 7 additions & 1 deletion Doc/library/shutil.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,12 +574,18 @@ provided. They rely on the :mod:`zipfile` and :mod:`tarfile` modules.

.. note::

This function is not thread-safe.
This function is not thread-safe when custom archivers registered
with :func:`register_archive_format` are used. In this case it
temporarily changes the current working directory of the process
to perform archiving.

.. versionchanged:: 3.8
The modern pax (POSIX.1-2001) format is now used instead of
the legacy GNU format for archives created with ``format="tar"``.

.. versionchanged:: 3.10.6
This function is now made thread-safe during creation of standard
``.zip`` and tar archives.

.. function:: get_archive_formats()

Expand Down
4 changes: 2 additions & 2 deletions Misc/NEWS.d/next/Library/2022-05-24-11-19-04.gh-issue-74696.-cnf-A.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
:func:`shutil.make_archive` no longer temporary change the current working
directory when create a standard zip or tar archive.
:func:`shutil.make_archive` no longer temporarily changes the current
working directory during creation of standard ``.zip`` or tar archives.
0