From daa6df1902206222b5394b4a035c9509b563054c Mon Sep 17 00:00:00 2001 From: sobolevn Date: Sat, 22 Jan 2022 22:26:12 +0300 Subject: [PATCH 1/3] bpo-41682: skip `test_sendfile_close_peer_in_the_middle_of_receiving` in `test_asyncio` --- Lib/test/test_asyncio/test_sendfile.py | 1 + 1 file changed, 1 insertion(+) diff --git a/Lib/test/test_asyncio/test_sendfile.py b/Lib/test/test_asyncio/test_sendfile.py index 57b56bba34100b..afa8fbd2697978 100644 --- a/Lib/test/test_asyncio/test_sendfile.py +++ b/Lib/test/test_asyncio/test_sendfile.py @@ -456,6 +456,7 @@ def test_sendfile_ssl_close_peer_after_receiving(self): # themselves). @unittest.skipIf(sys.platform.startswith('sunos'), "Doesn't work on Solaris") + @unittest.skip("It is flaky and needs to be fixed") # TODO: bpo-41682 def test_sendfile_close_peer_in_the_middle_of_receiving(self): srv_proto, cli_proto = self.prepare_sendfile(close_after=1024) with self.assertRaises(ConnectionError): From 688b13abad534fa9590ca322a4d10b50e4b4a3fd Mon Sep 17 00:00:00 2001 From: Nikita Sobolev Date: Sun, 23 Jan 2022 01:27:52 +0300 Subject: [PATCH 2/3] Update test_sendfile.py --- Lib/test/test_asyncio/test_sendfile.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Lib/test/test_asyncio/test_sendfile.py b/Lib/test/test_asyncio/test_sendfile.py index afa8fbd2697978..a851f0995a8043 100644 --- a/Lib/test/test_asyncio/test_sendfile.py +++ b/Lib/test/test_asyncio/test_sendfile.py @@ -456,7 +456,8 @@ def test_sendfile_ssl_close_peer_after_receiving(self): # themselves). @unittest.skipIf(sys.platform.startswith('sunos'), "Doesn't work on Solaris") - @unittest.skip("It is flaky and needs to be fixed") # TODO: bpo-41682 + @unittest.skipIf(sys.platform == "win32", + "It is flaky on win and needs to be fixed") # TODO: bpo-41682 def test_sendfile_close_peer_in_the_middle_of_receiving(self): srv_proto, cli_proto = self.prepare_sendfile(close_after=1024) with self.assertRaises(ConnectionError): From 3562150158a10542dca6b2e46bb2210774c86224 Mon Sep 17 00:00:00 2001 From: Nikita Sobolev Date: Sun, 23 Jan 2022 01:34:04 +0300 Subject: [PATCH 3/3] Update Lib/test/test_asyncio/test_sendfile.py --- Lib/test/test_asyncio/test_sendfile.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lib/test/test_asyncio/test_sendfile.py b/Lib/test/test_asyncio/test_sendfile.py index a851f0995a8043..c8bfa892c73fc6 100644 --- a/Lib/test/test_asyncio/test_sendfile.py +++ b/Lib/test/test_asyncio/test_sendfile.py @@ -457,7 +457,7 @@ def test_sendfile_ssl_close_peer_after_receiving(self): @unittest.skipIf(sys.platform.startswith('sunos'), "Doesn't work on Solaris") @unittest.skipIf(sys.platform == "win32", - "It is flaky on win and needs to be fixed") # TODO: bpo-41682 + "It is flaky on Windows and needs to be fixed") # TODO: bpo-41682 def test_sendfile_close_peer_in_the_middle_of_receiving(self): srv_proto, cli_proto = self.prepare_sendfile(close_after=1024) with self.assertRaises(ConnectionError):