bpo-24076: Fix reference in sum() introduced by GH-28469 #28493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 21, 2021
rhettinger
reviewed
Sep 21, 2021
Python/bltinmodule.c
Outdated
| @@ -2484,7 +2484,7 @@ builtin_sum_impl(PyObject *module, PyObject *iterable, PyObject *start) | |||
| /* Single digits are common, fast, and cannot overflow on unpacking. */ | |||
| switch (Py_SIZE(item)) { | |||
| case -1: b = -(sdigit) ((PyLongObject*)item)->ob_digit[0]; break; | |||
| case 0: continue; | |||
| case 0: Py_DECREF(item); continue; | |||
There was a problem hiding this comment.
I'm thinking that the "continue" warrants a comment. Inside a switch-case, a break ends a case but a continue means to go to the top of the loop. The side-by-side use of break and continue is a bit confusing (I did a double take when I first saw it); hence, my suggestion to add a comment.
There was a problem hiding this comment.
Agreed. I actually didn't add it before to keep the PR contained. But makes sense. I have pushed a comment in the new commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue24076