10000 [3.10] bpo-42972: Fully support GC for _winapi.Overlapped (GH-26381) by miss-islington · Pull Request #26426 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.10] bpo-42972: Fully support GC for _winapi.Overlapped (GH-26381) #26426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[3.10] bpo-42972: Fully support GC for _winapi.Overlapped (GH-26381) #26426

wants to merge 1 commit into from

Conversation

miss-islington
Copy link
Contributor
@miss-islington miss-islington commented May 28, 2021 •
edited by bedevere-bot
Loading

@Fidget-Spinner @miss-islington
bpo-42972: Fully support GC for _winapi.Overlapped (pythonGH-26381)
89ed8f6 
(cherry picked from commit 0fa282c)

Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
@miss-islington
Copy link
Contributor Author

@Fidget-Spinner and @vstinner: Status check is done, and it's a success ✅ .

@bedevere-bot bedevere-bot mentioned this pull request May 28, 2021
Merged
vstinner
vstinner approved these changes May 28, 2021
View reviewed changes
Copy link
Member
@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@Fidget-Spinner and @vstinner: Status check is done, and it's a success ❌ .

@Fidget-Spinner
Copy link
Member

Errors:

2021-05-28T09:19:40.5802159Z 3 tests failed:
2021-05-28T09:19:40.5802633Z     test_asyncio test_httplib test_importlib

asyncio's logs, these tests are known to be flaky and reported somewhere on bpo:

2021-05-28T09:18:08.9401293Z FAIL: test_sendfile_close_peer_in_the_middle_of_receiving (test.test_asyncio.test_sendfile.ProactorEventLoopTests)
2021-05-28T09:18:08.9402357Z ----------------------------------------------------------------------
2021-05-28T09:18:08.9402931Z Traceback (most recent call last):
2021-05-28T09:18:08.9403749Z   File "D:\a\cpython\cpython\lib\test\test_asyncio\test_sendfile.py", line 457, in test_sendfile_close_peer_in_the_middle_of_receiving
2021-05-28T09:18:08.9405206Z     with self.assertRaises(ConnectionError):
2021-05-28T09:18:08.9405959Z AssertionError: ConnectionError not raised

test_importlib errors: I've never seen this one before

2021-05-28T09:16:08.2062616Z ======================================================================
2021-05-28T09:16:08.2063656Z FAIL: test_multiprocessing_pool_circular_import (test.test_importlib.test_threaded_import.ThreadedImportTests)
2021-05-28T09:16:08.2064777Z ----------------------------------------------------------------------
2021-05-28T09:16:08.2065427Z Traceback (most recent call last):
2021-05-28T09:16:08.2066366Z   File "D:\a\cpython\cpython\lib\test\test_importlib\test_threaded_import.py", line 258, in test_multiprocessing_pool_circular_import
2021-05-28T09:16:08.2067891Z     script_helper.assert_python_ok(fn)
2021-05-28T09:16:08.2068847Z   File "D:\a\cpython\cpython\lib\test\support\script_helper.py", line 160, in assert_python_ok
2021-05-28T09:16:08.2069688Z     return _assert_python(True, *args, **env_vars)
2021-05-28T09:16:08.2070645Z   File "D:\a\cpython\cpython\lib\test\support\script_helper.py", line 145, in _assert_python
2021-05-28T09:16:08.2071564Z     res.fail(cmd_line)
2021-05-28T09:16:08.2072242Z   File "D:\a\cpython\cpython\lib\test\support\script_helper.py", line 72, in fail
2021-05-28T09:16:08.2073008Z     raise AssertionError("Process return code is %d\n"
2021-05-28T09:16:08.2073741Z AssertionError: Process return code is 3221225477
2021-05-28T09:16:08.2075029Z command line: ['D:\\a\\cpython\\cpython\\PCbuild\\amd64\\python.exe', '-X', 'faulthandler', '-I', 'D:\\a\\cpython\\cpython\\lib\\test\\test_importlib\\partial\\pool_in_threads.py']
2021-05-28T09:16:08.2075868Z 
2021-05-28T09:16:08.2076267Z stdout:
2021-05-28T09:16:08.2076663Z ---
2021-05-28T09:16:08.2076929Z 
2021-05-28T09:16:08.2077459Z ---
2021-05-28T09:16:08.2077744Z 
2021-05-28T09:16:08.2078110Z stderr:
2021-05-28T09:16:08.2078492Z ---
2021-05-28T09:16:08.2078789Z 
2021-05-28T09:16:08.2079162Z ---
2021-05-28T09:16:08.2079440Z 
2021-05-28T09:16:08.2080183Z ----------------------------------------------------------------------

httplib errors, this is already mentioned here https://bugs.python.org/issue44252:

2021-05-28T09:15:10.7551568Z Windows fatal exception: access violation
2021-05-28T09:15:10.7552292Z 0:03:29 load avg: 4.33 [231/427/1] test_httplib crashed (Exit code 3221225477)
2021-05-28T09:15:10.7575556Z 
2021-05-28T09:15:10.8138347Z Current thread 0x00001558 (most recent call first):
2021-05-28T09:15:10.8596401Z   File "D:\a\cpython\cpython\lib\ssl.py", line 1072 in _create
2021-05-28T09:15:10.8608169Z   File "D:\a\cpython\cpython\lib\ssl.py", line 518 in wrap_socket
2021-05-28T09:15:10.8616549Z   File "D:\a\cpython\cpython\lib\test\ssl_servers.py", line 37 in get_request
2021-05-28T09:15:10.8931572Z   File "D:\a\cpython\cpython\lib\socketserver.py", line 311 in _handle_request_noblock
2021-05-28T09:15:10.9022362Z   File "D:\a\cpython\cpython\lib\socketserver.py", line 237 in serve_forever
2021-05-28T09:15:10.9068369Z   File "D:\a\cpython\cpython\lib\test\ssl_servers.py", line 142 in run
2021-05-28T09:15:10.9087982Z   File "D:\a\cpython\cpython\lib\threading.py", line 1006 in _bootstrap_inner
2021-05-28T09:15:10.9127252Z   File "D:\a\cpython\cpython\lib\threading.py", line 963 in _bootstrap
2021-05-28T09:15:10.9768277Z 
2021-05-28T09:15:11.1399522Z Thread 0x0000058c (most recent call first):
2021-05-28T09:15:11.1537467Z   File "D:\a\cpython\cpython\lib\socket.py", line 496 in _real_close
2021-05-28T09:15:11.1876364Z   File "D:\a\cpython\cpython\lib\ssl.py", line 1330 in _real_close
2021-05-28T09:15:11.3695982Z   File "D:\a\cpython\cpython\lib\socket.py", line 502 in close
2021-05-28T09:15:11.3743399Z   File "D:\a\cpython\cpython\lib\ssl.py", line 1072 in _create

I have a feeling it's unrelated but I'm going to be cautious here - _winapi.Overlapped is used by asyncio on Windows so there's a chance. Gonna re-run the CI one more time. If it fails again then I'll start investigating.

@miss-islington miss-islington deleted the backport-0fa282c-3.10 branch May 28, 2021 09:39
@Fidget-Spinner
Copy link
Member
Fidget-Spinner commented May 28, 2021 •
edited
Loading

Dang I forgot miss-islington auto deletes backports when I close them :(. Sorry I'll make it backport again.

@vstinner
Copy link
Member

test_httplib crash is unrelated: https://bugs.python.org/issue44252

test_importlib: test_multiprocessing_pool_circular_import(): I wasn't aware of this crash, it sounds unrelated. Likely a random crash.

test_asyncio: test_sendfile_close_peer_in_the_middle_of_receiving(): it's also known and unrelated: https://bugs.python.org/issue41682

@vstinner vstinner mentioned this pull request Jun 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
awaiting merge skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @Fidget-Spinner @vstinner @the-knights-who-say-ni @bedevere-bot
0