8000 bpo-44165: optimise sqlite3 statement preparation by passing string size by erlend-aasland · Pull Request #26206 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-44165: optimise sqlite3 statement preparation by passing string size #26206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 2, 2021
Merged

bpo-44165: optimise sqlite3 statement preparation by passing string size #26206

merged 5 commits into from
Jun 2, 2021

Conversation

erlend-aasland
Copy link
Contributor
@erlend-aasland erlend-aasland commented May 18, 2021 •
edited
Loading

Quoting the SQLite docs, https://sqlite.org/c3ref/prepare.html:
"If the caller knows that the supplied string is nul-terminated, then
there is a small performance advantage to passing an nByte parameter
that is the number of bytes in the input string including the
nul-terminator."

https://bugs.python.org/issue44165

@erlend-aasland
Copy link
Contributor Author

@pablogsal I recon this can pass as skip news. This is an internal micro-optimisation only. No user visible change.

pablogsal
pablogsal reviewed May 19, 2021
View reviewed changes
pablogsal
pablogsal reviewed May 19, 2021
View reviewed changes
@pablogsal pablogsal merged commit a384b6c into python:main Jun 2, 2021
pablogsal
pablogsal reviewed Jun 2, 2021
View reviewed changes
pablogsal
pablogsal reviewed Jun 2, 2021
View reviewed changes
@erlend-aasland erlend-aasland deleted the sqlite-prepare branch June 2, 2021 12:30
@python python deleted a comment from bedevere-bot Jun 2, 2021
@python python deleted a comment from bedevere-bot Jun 2, 2021
@erlend-aasland
Copy link
Contributor Author

This PR was broken by fffa0f9. I'll resolve the issues in a new PR.

erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Jun 2, 2021
pysqlite_statement_create now returns a Py object, not an int
448ad9d 
pythonGH-26206 was broken by pythonGH-26475.
@erlend-aasland erlend-aasland mentioned this pull request Jun 2, 2021
Merged
pablogsal pushed a commit that referenced this pull request Jun 2, 2021
bpo-44165: pysqlite_statement_create now returns a Py object, not an …
fbf25b8 
…int (GH-26484)

GH-26206 was broken by GH-26475.
@erlend-aasland erlend-aasland mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erlend-aasland @pablogsal @the-knights-who-say-ni @bedevere-bot
0