Add suffix

python · miss-islington · May 14, 2021 · May 14, 2021 · May 14, 2021 · May 14, 2021
commit c482e560d15f50fa2bef95ea6da7fb720dcfeb1c
diff --git a/Lib/test/test_zipfile.py b/Lib/test/test_zipfile.py
@@ -3093,6 +3093,25 @@ def test_root_name(self, alpharep):
         root = zipfile.Path(alpharep)
         assert root.name == 'alpharep.zip' == root.filename.name
 
+    @pass_alpharep
+    def test_suffix(self, alpharep):
+        """
+        The suffix of the root should be the suffix of the zipfile.
+        The suffix of each nested file is the final component's last suffix, if any.
+        Includes the leading period, just like pathlib.Path.
+        """
+        root = zipfile.Path(alpharep)
+        assert root.suffix == '.zip' == root.filename.suffix
+
+        b = root / "b.txt"
+        assert b.suffix == ".txt"
+
+        c = root / "c" / "filename.tar.gz"
+        assert c.suffix == ".gz"
+
+        d = root / "d"
+        assert d.suffix == ""
+
     @pass_alpharep
     def test_root_parent(self, alpharep):
         root = zipfile.Path(alpharep)

diff --git a/Lib/zipfile.py b/Lib/zipfile.py
@@ -2342,6 +2342,10 @@ def open(self, mode='r', *args, pwd=None, **kwargs):
     def name(self):
         return pathlib.Path(self.at).name or self.filename.name
 
+    @property
+    def suffix(self):
+        return pathlib.Path(self.at).suffix or self.filename.suffix
+
     @property
     def filename(self):
         return pathlib.Path(self.root.filename).joinpath(self.at)