bpo-41986: Add Py_FileSystemDefaultEncodeErrors and Py_UTF8Mode back to limited API #22621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
approved these changes
Oct 10, 2020
There was a problem hiding this comment.
LGTM. You fixed a mistake that I did.
First, I consider that the PR is wrong, but then I understood that your PR is right :-D
https://bugs.python.org/issue41986
Deprecating global configuration variables must be addressed separately: you can ignore my remark about that.
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 10, 2020
…to limited API (pythonGH-22621) (cherry picked from commit 637a09b) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-22637 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 10, 2020
…to limited API (pythonGH-22621) (cherry picked from commit 637a09b) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-22638 is a backport of this pull request to the 3.8 branch. |
|
Thank you @vstinner. |
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue41986