8000 Adding missing acknowledgement by Kentzo · Pull Request #17130 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Adding missing acknowledgement #17130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2019
Merged

Adding missing acknowledgement #17130

merged 1 commit into from
Nov 13, 2019

Conversation

Kentzo
Copy link
Contributor
@Kentzo Kentzo commented Nov 12, 2019 •
edited by bedevere-bot
Loading

Due to:
[bpo-26467](#9296): large chunk of the "based on" Apache 2.0 licensed code
[bpo-29302](#4790)

@Kentzo
Missing ack
387ffc7 
bpo-26467: large chunk of the "based on" code
bpo-29302
@brandtbucher brandtbucher added skip issue skip news docs Documentation in the Doc dir labels Nov 12, 2019
brandtbucher
brandtbucher approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member
@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help!

@benjaminp benjaminp merged commit d6d6e2a into python:master Nov 13, 2019
@miss-islington
Copy link
Contributor

Thanks @Kentzo for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-17138 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Nov 13, 2019
@miss-islington @Kentzo
Add Ilya Kulakov to Misc/ACKS. (GH-17130)
e5125f7 
Contributions on bpo-26467 and bpo-29302.
(cherry picked from commit d6d6e2a)

Co-authored-by: Ilya Kulakov <kulakov.ilya@gmail.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@Kentzo
Add Ilya Kulakov to Misc/ACKS. (pythonGH-17130)
9844b12 
Contributions on bpo-26467 and bpo-29302.
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@Kentzo @shihai1991
Add Ilya Kulakov to Misc/ACKS. (pythonGH-17130)
39c406a 
Contributions on bpo-26467 and bpo-29302.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Kentzo @miss-islington @bedevere-bot @brandtbucher @benjaminp @the-knights-who-say-ni
0