8000 bpo-38248: Fix inconsistent immediate asyncio.Task cancellation by 1st1 · Pull Request #16330 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-38248: Fix inconsistent immediate asyncio.Task cancellation #16330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2019
Merged

bpo-38248: Fix inconsistent immediate asyncio.Task cancellation #16330

merged 1 commit into from
Sep 25, 2019

Conversation

1st1
Copy link
Member
@1st1 1st1 commented Sep 22, 2019 •
edited by bedevere-bot
Loading

@1st1 1st1 requested a review from asvetlov September 22, 2019 20:07
@njsmith
Copy link
Contributor
njsmith commented Sep 22, 2019

Looks good to me.

asvetlov
asvetlov approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor
@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@willingc willingc merged commit edad4d8 into python:master Sep 25, 2019
@miss-islington
Copy link
Contributor

Thanks @1st1 for the PR, and @willingc for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-16383 is a backport of this pull request to the 3.8 branch.

willingc pushed a commit that referenced this pull request Sep 25, 2019
@miss-islington @1st1 @willingc
bpo-38248: Fix inconsistent immediate asyncio.Task cancellation (GH-1…
16cec13 
…6330) (GH-16383)

(cherry picked from commit edad4d8)

Co-authored-by: Yury Selivanov <yury@edgedb.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@1st1
bpo-38248: Fix inconsistent immediate asyncio.Task cancellation (pyth…
5dd136d 
…onGH-16330)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@willingc willingc willingc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@1st1 @njsmith @miss-islington @bedevere-bot @asvetlov @willingc @the-knights-who-say-ni
0