8000 gh-135386: Fix "unable to open database file" errors on readonly DB by GeneralK1ng · Pull Request #135566 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

gh-135386: Fix "unable to open database file" errors on readonly DB #135566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
gh-135386: Fix dbm.sqlite3 readonly open error by using immutable=1
  • Loading branch information
blurb-it[bot] authored and GeneralK1ng committed Jun 17, 2025
commit 3e3a3ba6c6f1a8ea747e08b3d1ad6b098366d4b6
1 change: 1 addition & 0 deletions Lib/dbm/sqlite3.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ def __init__(self, path, /, *, flag, mode):
self._cx = sqlite3.connect(uri, autocommit=True, uri=True)
except sqlite3.Error as exc:
raise error(str(exc))

self._readonly = (flag == "ro")
# This is an optimization only; it's ok if it fails.
if not self._readonly:
Expand Down
17 changes: 17 additions & 0 deletions Lib/test/test_dbm_sqlite3.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import os
import sys
import unittest
from contextlib import closing
Expand Down Expand Up @@ -89,6 +90,22 @@ def test_readonly_keys(self):
def test_readonly_iter(self):
self.assertEqual([k for k in self.db], [b"key1", b"key2"])

def test_readonly_open_without_wal_shm(self):
wal_path = self.filename + "-wal"
shm_path = self.filename + "-shm"

for suffix in wal_path, shm_path:
try:
os.remove(suffix)
except FileNotFoundError:
pass

os.chmod(self.filename, 0o444)

with dbm_sqlite3.open(self.filename, "r") as db:
self.assertEqual(db[b"key1"], b"value1")
self.assertEqual(db[b"key2"], b"value2")


class ReadWrite(_SQLiteDbmTests):

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix :exc:`sqlite3.OperationalError` error when using :func:`dbm.open` with a read-only file object.
Loading
0