gh-81313: Add the imath module #133909
gh-81313: Add the imath module #133909
Conversation
|
This is a further development of #13741. |
|
A PEP is being written for this module: skirpichev/peps#8 |
|
cc @skirpichev |
| .. function:: ilog2(n) | ||
|
|
||
| Return the integer base 2 logarithm of the positive integer *n*. This is the | ||
| floor of the exact base 2 logarithm root of *n*, or equivalently the | ||
| greatest integer *k* such that | ||
| 2\ :sup:`k` |nbsp| ≤ |nbsp| *n* |nbsp| < |nbsp| 2\ :sup:`k+1`. | ||
|
|
||
| It is equivalent to ``n.bit_length() - 1`` for positive *n*. |
There was a problem hiding this comment.
This function seems redundant.
Also, I think it's better to first just plain moving of functions. No new features.
There was a problem hiding this comment.
I'll remove it if you with.
Initially I planned to add more functions (in addition to new functions isqrt(), perm() and comb()). ilog2() is similar to int.bit_length(), but uses __index__(). After our discussion about math.log() I think that there is also a use case for 2-argument ilog() (to determine the number of decimal digits in a number, for example). But this is a different issue.
There was a problem hiding this comment.
As any addition to the stdlib, I think it deserves at least own issue. Lets just settle up the new module and move things properly.
| These functions accept integers and objects that implement the | ||
| :meth:`~object.__index__` method which is used to convert the object to an integer |
There was a problem hiding this comment.
In the same way we could simplify now description of argument processing in the math module. Except for a special snowflake "log" - all use PyFloat_AsDouble(). (Well, few functions also try special dunder methods.)
Though, probably it's for following prs.
|
I think that the PEP should be written before we handle this issue. |
|
📚 Documentation preview 📚: https://cpython-previews--133909.org.readthedocs.build/