8000 [GH-133419] fix test_external_inspection race assert by gpshead · Pull Request #133422 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

[GH-133419] fix test_external_inspection race assert #133422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gpshead
Copy link
Member
@gpshead gpshead commented May 5, 2025

either line could be where the inspection finds the foo() function as after ready is sent, the process may not have made progress onto the next line yet. "solve" by putting the statements on the same line. simpler than asserting for multiple possible line values.

Fixes #133419.
Closes #133419.

either line could be where the inspection finds the foo()
function as after ready is sent, the process may not have made progress
onto the next line yet.  "solve" by putting the statements on the same
line.
@gpshead gpshead added the tests Tests in the Lib/test dir label May 5, 2025
@gpshead gpshead requested a review from pablogsal May 5, 2025 04:16
@gpshead gpshead enabled auto-merge (squash) May 5, 2025 04:17
@gpshead gpshead merged commit c4cc5d5 into python:main May 5, 2025
44 checks passed
@vstinner
Copy link
Member
vstinner commented May 5, 2025

This change doesn't fix all tests, it's incomplete. I wrote #133433 to fix more tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_external_inspection fails on Ubuntu
2 participants
0