8000 GH-125515: Remove two unused error branches. by freakboy3742 · Pull Request #133181 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

GH-125515: Remove two unused error branches. #133181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 30, 2025
Merged

GH-125515: Remove two unused error branches. #133181

merged 3 commits into from
Apr 30, 2025

Conversation

freakboy3742
Copy link
Contributor
@freakboy3742 freakboy3742 commented Apr 30, 2025 •
edited by bedevere-app bot
Loading

Removes two unused error handling branches from the generated bytecode handling; these were raising unreachable code warnings on macOS.

@bedevere-app bedevere-app bot mentioned this pull request Apr 30, 2025
Closed
@freakboy3742
Copy link
Contributor Author

!buildbot iOS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 47c304e 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133181%2Fmerge

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR

sobolevn
sobolevn approved these changes Apr 30, 2025
View reviewed changes
Copy link
Member
@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning is gone, thanks!

@freakboy3742 freakboy3742 enabled auto-merge (squash) April 30, 2025 08:09
@freakboy3742 freakboy3742 disabled auto-merge April 30, 2025 08:31
markshannon
markshannon approved these changes Apr 30, 2025
View reviewed changes
Copy link
Member
@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. thanks for tidying up after us 🙂

@freakboy3742 freakboy3742 merged commit 6c522de into python:main Apr 30, 2025
63 checks passed
@freakboy3742 freakboy3742 deleted the ununsed-branches branch April 30, 2025 22:21
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable Clang Installed 3.x (tier-2) has failed when building commit 6c522de.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/14/builds/7693) and take a look at the build logs.
  4. Check if the failure is related to this commit (6c522de) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/14/builds/7693

Failed tests:

  • test_functools

Summary of the results of the build (if available):

==

Click to see traceback logs 
Note: switching to '6c522debc218d441756bf631abe8ec8d6c6f1c45'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 6c522debc21 GH-125515: Remove two unused error branches. (#133181)
Switched to and reset branch 'main'

  WARNING: The scripts pip3 and pip3.14 are installed in '/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

@markshannon markshannon markshannon approved these changes

@brandtbucher brandtbucher Awaiting requested review from brandtbucher

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@freakboy3742 @bedevere-bot @sobolevn @markshannon
0