8000 gh-133079: Remove Py_C_RECURSION_LIMIT & PyThreadState.c_recursion_remaining by encukou · Pull Request #133080 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-133079: Remove Py_C_RECURSION_LIMIT & PyThreadState.c_recursion_remaining #133080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

gh-133079: Remove Py_C_RECURSION_LIMIT & PyThreadState.c_recursion_remaining #133080

merged 1 commit into from
Apr 29, 2025

Conversation

encukou
Copy link
Member
@encukou encukou commented Apr 28, 2025 •
edited by github-actions bot
Loading

Both were added in 3.13, are undocumented, and don't make sense in 3.14 due to changes in the stack overflow detection machinery (gh-112282).

PEP 387 exception for skipping a deprecation period: python/steering-council#288

📚 Documentation preview 📚: https://cpython-previews--133080.org.readthedocs.build/

@encukou
pythongh-133079: Remove Py_C_RECURSION_LIMIT & PyThreadState.c_recurs…
4e1690b 
…ion_remaining

Both were added in 3.13, are undocumented, and don't make sense in 3.14 due to
changes in the stack overflow detection machinery (pythongh-112282).
@bedevere-app bedevere-app bot mentioned this pull request Apr 28, 2025
Closed
corona10
corona10 approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member
@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

vstinner
vstinner approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member
@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@encukou encukou merged commit 0c26dbd into python:main Apr 29, 2025
49 checks passed
@encukou encukou deleted the remove-Py_C_RECURSION_LIMIT branch April 29, 2025 10:57
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Android 3.x (tier-3) has failed when building commit 0c26dbd.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1594/builds/2140) and take a look at the build logs.
  4. Check if the failure is related to this commit (0c26dbd) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1594/builds/2140

Summary of the results of the build (if available):

Click to see traceback logs 
remote: Enumerating objects: 16, done.        
remote: Counting objects:   7% (1/14)        
remote: Counting objects:  14% (2/14)        
remote: Counting objects:  21% (3/14)        
remote: Counting objects:  28% (4/14)        
remote: Counting objects:  35% (5/14)        
remote: Counting objects:  42% (6/14)        
remote: Counting objects:  50% (7/14)        
remote: Counting objects:  57% (8/14)        
remote: Counting objects:  64% (9/14)        
remote: Counting objects:  71% (10/14)        
remote: Counting objects:  78% (11/14)        
remote: Counting objects:  85% (12/14)        
remote: Counting objects:  92% (13/14)        
remote: Counting objects: 100% (14/14)        
remote: Counting objects: 100% (14/14), done.        
remote: Compressing objects:  10% (1/10)        
remote: Compressing objects:  20% (2/10)        
remote: Compressing objects:  30% (3/10)        
remote: Compressing objects:  40% (4/10)        
remote: Compressing objects:  50% (5/10)        
remote: Compressing objects:  60% (6/10)        
remote: Compressing objects:  70% (7/10)        
remote: Compressing objects:  80% (8/10)        
remote: Compressing objects:  90% (9/10)        
remote: Compressing objects: 100% (10/10)        
remote: Compressing objects: 100% (10/10), done.        
remote: Total 16 (delta 4), reused 4 (delta 4), pack-reused 2 (from 1)        
From https://github.com/python/cpython
 * branch                    main       -> FETCH_HEAD
Note: switching to '0c26dbd16e9dd71a52d3ebd43d692f0cd88a3a37'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 0c26dbd16e9 gh-133079: Remove Py_C_RECURSION_LIMIT & PyThreadState.c_recursion_remaining (GH-133080)
Switched to and reset branch 'main'

configure: WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)
configure: WARNING: pkg-config is missing. Some dependencies may not be detected correctly.

In file included from ../../Python/ceval.c:1097:
../../Python/generated_cases.c.h:12162:13: warning: code will never be executed [-Wunreachable-code]
 12162 |             stack_pointer -= 3;
       |             ^~~~~~~~~~~~~
../../Python/generated_cases.c.h:12155:13: warning: code will never be executed [-Wunreachable-code]
 12155 |             stack_pointer -= 4;
       |             ^~~~~~~~~~~~~
../../Python/generated_cases.c.h:7467:13: warning: code will never be executed [-Wunreachable-code]
 7467 |             stack_pointer += -1;
      |             ^~~~~~~~~~~~~
3 warnings generated.
ld: warning: ignoring duplicate libraries: '-ldl'
ld: warning: ignoring duplicate libraries: '-ldl'
ld: warning: ignoring duplicate libraries: '-ldl'
ld: warning: ignoring duplicate libraries: '-ldl'
ld: warning: ignoring duplicate libraries: '-ldl'
ld: warning: ignoring duplicate libraries: '-ldl'

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0

100  192k  100  192k    0     0  1998k      0 --:--:-- --:--:-- --:--:-- 1998k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0

100 42455  100 42455    0     0   389k      0 --:--:-- --:--:-- --:--:--  389k
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0

100 5041k  100 5041k    0     0  37.6M      0 --:--:-- --:--:-- --:--:-- 37.6M
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0

  0   544    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (56) The requested URL returned error: 403

@iritkatriel
Copy link
Member
iritkatriel commented May 10, 2025 •
edited
Loading

This seems to have broken uWSGI build on our benchmarking run:

plugins/python/python_plugin.c:1629:51: error: ‘PyThreadState’ {aka ‘struct _ts’} has no member named ‘c_recursion_remaining’; did you mean ‘py_recursion_remaining’?
       1629 |   up.current_main_c_recursion_remaining = tstate->c_recursion_remaining;
            |                                                   ^~~~~~~~~~~~~~~~~~~~~
            |                                                   py_recursion_remaining

See https://github.com/faster-cpython/benchmarking/actions/runs/14754424278/job/41419104378.

CC @hugovk

@hugovk
Copy link
Member
hugovk commented May 10, 2025

See faster-cpython/benchmarking/actions/runs/14754424278/job/41419104378.

This link is 404/hidden for non https://github.com/faster-cpython/benchmarking members.

@iritkatriel
Copy link
Member

This link is 404/hidden for non https://github.com/faster-cpython/benchmarking members.

Sorry, here is more output:


Building wheels for collected packages: kinto, uWSGI
  Building wheel for kinto (pyproject.toml): started
  Building wheel for kinto (pyproject.toml): finished with status 'done'
  Created wheel for kinto: filename=kinto-14.2.0-cp3-none-any.whl size=1806532 sha256=aee21568a6a4a17f76d8a16059fcb45ac1b644a8d01c04ed7ca6d3eb2f4ee997
  Stored in directory: /home/benchmarking/.cache/pip/wheels/46/c5/9b/183a200bbbb244c4f94186c0158d4ff8a1e215d3ebb68f3ae6
  Building wheel for uWSGI (setup.py): started
  Building wheel for uWSGI (setup.py): finished with status 'error'
  error: subprocess-exited-with-error
  
  × python setup.py bdist_wheel did not run successfully.
  │ exit code: 1
  ╰─> [197 lines of output]
      /home/benchmarking/actions-runner/_work/benchmarking/benchmarking/venv/cpython3.14-ee88948380c0-compat-64aaec271e6b-bm-kinto/lib/python3.14/site-packages/setuptools/_distutils/dist.py:289: UserWarning: Unknown distribution option: 'descriptions'
        warnings.warn(msg)
      /home/benchmarking/actions-runner/_work/benchmarking/benchmarking/venv/cpython3.14-ee88948380c0-compat-64aaec271e6b-bm-kinto/lib/python3.14/site-packages/setuptools/dist.py:759: SetuptoolsDeprecationWarning: License classifiers are deprecated.
      !!
      
              ********************************************************************************
              Please consider removing the following classifiers in favor of a SPDX license expression:
      
              License :: OSI Approved :: GNU General Public License v2 or later (GPLv2+)
      
              See https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#license for details.
              ********************************************************************************
      
      !!
        self._finalize_license_expression()
      running bdist_wheel
      running build
      running build_py
      creating build/lib
      copying uwsgidecorators.py -> build/lib
      /home/benchmarking/actions-runner/_work/benchmarking/benchmarking/venv/cpython3.14-ee88948380c0-compat-64aaec271e6b-bm-kinto/lib/python3.14/site-packages/setuptools/_distutils/cmd.py:90: SetuptoolsDeprecationWarning: setup.py install is deprecated.
      !!
      
              ********************************************************************************
              Please avoid running ``setup.py`` directly.
              Instead, use pypa/build, pypa/installer or other
              standards-based tools.
      
              See https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html for details.
              ********************************************************************************
      
      !!
        self.initialize_options()
      installing to build/bdist.linux-x86_64/wheel
      running install
      using profile: buildconf/default.ini
      detected include path: ['/usr/lib/gcc/x86_64-linux-gnu/9/include', '/usr/local/include', '/usr/include/x86_64-linux-gnu', '/usr/include']
      Patching "bin_name" to properly install_scripts dir
      detected CPU cores: 20
      configured CFLAGS: -O2 -I. -Wall -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wformat-signedness -DUWSGI_HAS_IFADDRS -DUWSGI_ZLIB -DUWSGI_LOCK_USE_MUTEX -DUWSGI_EVENT_USE_EPOLL -DUWSGI_EVENT_TIMER_USE_TIMERFD -DUWSGI_EVENT_FILEMONITOR_USE_INOTIFY -DUWSGI_UUID -DUWSGI_VERSION="\"2.0.28\"" -DUWSGI_VERSION_BASE="2" -DUWSGI_VERSION_MAJOR="0" -DUWSGI_VERSION_MINOR="28" -DUWSGI_VERSION_REVISION="0" -DUWSGI_VERSION_CUSTOM="\"\"" -DUWSGI_YAML -DUWSGI_SSL -I/usr/include/libxml2 -DUWSGI_XML -DUWSGI_XML_LIBXML2 -DUWSGI_PLUGIN_DIR="\".\"" -DUWSGI_DECLARE_EMBEDDED_PLUGINS="UDEP(python);UDEP(gevent);UDEP(ping);UDEP(cache);UDEP(nagios);UDEP(rrdtool);UDEP(carbon);UDEP(rpc);UDEP(corerouter);UDEP(fastrouter);UDEP(http);UDEP(ugreen);UDEP(signal);UDEP(syslog);UDEP(rsyslog);UDEP(logsocket);UDEP(router_uwsgi);UDEP(router_redirect);UDEP(router_basicauth);UDEP(zergpool);UDEP(redislog);UDEP(mongodblog);UDEP(router_rewrite);UDEP(router_http);UDEP(logfile);UDEP(router_cache);UDEP(rawrouter);UDEP(router_static);UDEP(sslrouter);UDEP(spooler);UDEP(cheaper_busyness);UDEP(symcall);UDEP(transformation_tofile);UDEP(transformation_gzip);UDEP(transformation_chunked);UDEP(transformation_offload);UDEP(router_memcached);UDEP(router_redis);UDEP(router_hash);UDEP(router_expires);UDEP(router_metrics);UDEP(transformation_template);UDEP(stats_pusher_socket);" -DUWSGI_LOAD_EMBEDDED_PLUGINS="ULEP(python);ULEP(gevent);ULEP(ping);ULEP(cache);ULEP(nagios);ULEP(rrdtool);ULEP(carbon);ULEP(rpc);ULEP(corerouter);ULEP(fastrouter);ULEP(http);ULEP(ugreen);ULEP(signal);ULEP(syslog);ULEP(rsyslog);ULEP(logsocket);ULEP(router_uwsgi);ULEP(router_redirect);ULEP(router_basicauth);ULEP(zergpool);ULEP(redislog);ULEP(mongodblog);ULEP(router_rewrite);ULEP(router_http);ULEP(logfile);ULEP(router_cache);ULEP(rawrouter);ULEP(router_static);ULEP(sslrouter);ULEP(spooler);ULEP(cheaper_busyness);ULEP(symcall);ULEP(transformation_tofile);ULEP(transformation_gzip);ULEP(transformation_chunked);ULEP(transformation_offload);ULEP(router_memcached);ULEP(router_redis);ULEP(router_hash);ULEP(router_expires);ULEP(router_metrics);ULEP(transformation_template);ULEP(stats_pusher_socket);"
      *** uWSGI compiling server core ***
      [thread 0][gcc -pthread] core/socket.o
      [thread 6][gcc -pthread] core/master.o
      [thread 10][gcc -pthread] core/subscription.o
      [thread 1][gcc -pthread] core/utils.o
      [thread 4][gcc -pthread] core/master_utils.o
      [thread 3][gcc -pthread] core/protocol.o
      [thread 2][gcc -pthread] core/emperor.o
      [thread 7][gcc -pthread] core/notify.o
      [thread 9][gcc -pthread] core/mule.o
      [thread 5][gcc -pthread] core/logging.o
      [thread 11][gcc -pthread] core/stats.o
      [thread 14][gcc -pthread] core/sendfile.o
      [thread 15][gcc -pthread] core/async.o
      [thread 16][gcc -pthread] core/master_checks.o
      [thread 12][gcc -pthread] core/fifo.o
      [thread 13][gcc -pthread] core/offload.o
      [thread 17][gcc -pthread] core/io.o
      [thread 18][gcc -pthread] core/static.o
      [thread 19][gcc -pthread] core/websockets.o
      [thread 8][gcc -pthread] core/spooler.o
      [thread 7][gcc -pthread] core/snmp.o
      [thread 14][gcc -pthread] core/exceptions.o
      [thread 12][gcc -pthread] core/config.o
      [thread 19][gcc -pthread] core/setup_utils.o
      [thread 18][gcc -pthread] core/clock.o
      [thread 13][gcc -pthread] core/init.o
      [thread 11][gcc -pthread] core/buffer.o
      [thread 8][gcc -pthread] core/reader.o
      [thread 16][gcc -pthread] core/writer.o
      [thread 15][gcc -pthread] core/alarm.o
      [thread 9][gcc -pthread] core/cron.o
      [thread 6][gcc -pthread] core/hooks.o
      [thread 19][gcc -pthread] core/plugins.o
      [thread 10][gcc -pthread] core/lock.o
      [thread 14][gcc -pthread] core/cache.o
      [thread 7][gcc -pthread] core/daemons.o
      [thread 3][gcc -pthread] core/errors.o
      [thread 18][gcc -pthread] core/hash.o
      [thread 4][gcc -pthread] core/master_events.o
      [thread 5][gcc -pthread] core/chunked.o
      [thread 0][gcc -pthread] core/queue.o
      [thread 12][gcc -pthread] core/event.o
      [thread 17][gcc -pthread] core/signal.o
      [thread 11][gcc -pthread] core/strings.o
      [thread 13][gcc -pthread] core/progress.o
      [thread 9][gcc -pthread] core/timebomb.o
      [thread 2][gcc -pthread] core/ini.o
      [thread 8][gcc -pthread] core/fsmon.o
      [thread 19][gcc -pthread] core/mount.o
      [thread 15][gcc -pthread] core/metrics.o
      [thread 3][gcc -pthread] core/plugins_builder.o
      [thread 6][gcc -pthread] core/sharedarea.o
      [thread 16][gcc -pthread] core/rpc.o
      [thread 10][gcc -pthread] core/gateway.o
      [thread 18][gcc -pthread] core/loop.o
      [thread 7][gcc -pthread] core/cookie.o
      [thread 0][gcc -pthread] core/querystring.o
      [thread 4][gcc -pthread] core/rb_timers.o
      [thread 9][gcc -pthread] core/transformations.o
      [thread 5][gcc -pthread] core/uwsgi.o
      [thread 13][gcc -pthread] proto/base.o
      [thread 11][gcc -pthread] proto/uwsgi.o
      [thread 12][gcc -pthread] proto/http.o
      [thread 17][gcc -pthread] proto/fastcgi.o
      [thread 2][gcc -pthread] proto/scgi.o
      [thread 8][gcc -pthread] proto/puwsgi.o
      [thread 19][gcc -pthread] lib/linux_ns.o
      [thread 3][gcc -pthread] core/zlib.o
      [thread 7][gcc -pthread] core/yaml.o
      [thread 16][gcc -pthread] core/ssl.o
      [thread 10][gcc -pthread] core/legion.o
      [thread 18][gcc -pthread] core/xmlconf.o
      [thread 0][gcc -pthread] core/dot_h.o
      [thread 9][gcc -pthread] core/config_py.o
      *** uWSGI compiling embedded plugins ***
      [thread 0][gcc -pthread] plugins/python/python_plugin.o
      [thread 9][gcc -pthread] plugins/python/pyutils.o
      [thread 6][gcc -pthread] plugins/python/pyloader.o
      [thread 1][gcc -pthread] plugins/python/wsgi_handlers.o
      [thread 4][gcc -pthread] plugins/python/wsgi_headers.o
      [thread 11][gcc -pthread] plugins/python/wsgi_subhandler.o
      [thread 14][gcc -pthread] plugins/python/web3_subhandler.o
      [thread 13][gcc -pthread] plugins/python/pump_subhandler.o
      [thread 8][gcc -pthread] plugins/python/gil.o
      [thread 2][gcc -pthread] plugins/python/uwsgi_pymodule.o
      [thread 3][gcc -pthread] plugins/python/profiler.o
      [thread 17][gcc -pthread] plugins/python/symimporter.o
      [thread 15][gcc -pthread] plugins/python/tracebacker.o
      [thread 7][gcc -pthread] plugins/python/raw.o
      [thread 19][gcc -pthread] plugins/gevent/gevent.o
      [thread 18][gcc -pthread] plugins/gevent/hooks.o
      plugins/python/python_plugin.c:138:2: warning: ‘Py_NoSiteFlag’ is deprecated [-Wdeprecated-declarations]
        138 |  {"no-site", no_argument, 0, "do not import site module", uwsgi_opt_true, &Py_NoSiteFlag, 0},
            |  ^
      In file included from /home/benchmarking/actions-runner/_work/benchmarking/benchmarking/cpython/Include/Python.h:78,
                       from plugins/python/uwsgi_python.h:4,
                       from plugins/python/python_plugin.c:1:
      /home/benchmarking/actions-runner/_work/benchmarking/benchmarking/cpython/Include/cpython/pydebug.h:14:37: note: declared here
         14 | Py_DEPRECATED(3.12) PyAPI_DATA(int) Py_NoSiteFlag;
            |                                     ^~~~~~~~~~~~~
      plugins/python/pyutils.c: In function ‘init_pyargv’:
      plugins/python/pyutils.c:391:2: warning: ‘PySys_SetArgv’ is deprecated [-Wdeprecated-declarations]
        391 |  PySys_SetArgv(up.argc, up.py_argv);
            |  ^~~~~~~~~~~~~
      In file included from /home/benchmarking/actions-runner/_work/benchmarking/benchmarking/cpython/Include/Python.h:127,
                       from plugins/python/uwsgi_python.h:4,
                       from plugins/python/pyutils.c:1:
      /home/benchmarking/actions-runner/_work/benchmarking/benchmarking/cpython/Include/sysmodule.h:10:38: note: declared here
         10 | Py_DEPRECATED(3.11) PyAPI_FUNC(void) PySys_SetArgv(int, wchar_t **);
            |                                      ^~~~~~~~~~~~~
      plugins/python/python_plugin.c: In function ‘uwsgi_python_init’:
      plugins/python/python_plugin.c:254:3: warning: ‘Py_SetPythonHome’ is deprecated [-Wdeprecated-declarations]
        254 |   Py_SetPythonHome(wpyhome);
            |   ^~~~~~~~~~~~~~~~
      In file included from /home/benchmarking/actions-runner/_work/benchmarking/benchmarking/cpython/Include/Python.h:125,
                       from plugins/python/uwsgi_python.h:4,
                       from plugins/python/python_plugin.c:1:
      /home/benchmarking/actions-runner/_work/benchmarking/benchmarking/cpython/Include/pylifecycle.h:40:38: note: declared here
         40 | Py_DEPRECATED(3.11) PyAPI_FUNC(void) Py_SetPythonHome(const wchar_t *);
            |                                      ^~~~~~~~~~~~~~~~
      plugins/python/python_plugin.c:278:2: warning: ‘Py_SetProgramName’ is deprecated [-Wdeprecated-declarations]
        278 |  Py_SetProgramName(pname);
            |  ^~~~~~~~~~~~~~~~~
      In file included from /home/benchmarking/actions-runner/_work/benchmarking/benchmarking/cpython/Include/Python.h:125,
                       from plugins/python/uwsgi_python.h:4,
                       from plugins/python/python_plugin.c:1:
      /home/benchmarking/actions-runner/_work/benchmarking/benchmarking/cpython/Include/pylifecycle.h:37:38: note: declared here
         37 | Py_DEPRECATED(3.11) PyAPI_FUNC(void) Py_SetProgramName(const wchar_t *);
            |                                      ^~~~~~~~~~~~~~~~~
      plugins/python/python_plugin.c:287:2: warning: ‘Py_OptimizeFlag’ is deprecated [-Wdeprecated-declarations]
        287 |  Py_OptimizeFlag = up.optimize;
            |  ^~~~~~~~~~~~~~~
      In file included from /home/benchmarking/actions-runner/_work/benchmarking/benchmarking/cpython/Include/Python.h:78,
                       from plugins/python/uwsgi_python.h:4,
                       from plugins/python/python_plugin.c:1:
      /home/benchmarking/actions-runner/_work/benchmarking/benchmarking/cpython/Include/cpython/pydebug.h:13:37: note: declared here
         13 | Py_DEPRECATED(3.12) PyAPI_DATA(int) Py_OptimizeFlag;
            |                                     ^~~~~~~~~~~~~~~
      plugins/python/python_plugin.c: In function ‘uwsgi_python_suspend’:
      plugins/python/python_plugin.c:1612:66: error: ‘PyThreadState’ {aka ‘struct _ts’} has no member named ‘c_recursion_remaining’; did you mean ‘py_recursion_remaining’?
       1612 |   up.current_c_recursion_remaining[wsgi_req->async_id] = tstate->c_recursion_remaining;
            |                                                                  ^~~~~~~~~~~~~~~~~~~~~
            |                                                                  py_recursion_remaining
      plugins/python/python_plugin.c:1629:51: error: ‘PyThreadState’ {aka ‘struct _ts’} has no member named ‘c_recursion_remaining’; did you mean ‘py_recursion_remaining’?
       1629 |   up.current_main_c_recursion_remaining = tstate->c_recursion_remaining;
            |                                                   ^~~~~~~~~~~~~~~~~~~~~
            |                                                   py_recursion_remaining
      plugins/python/python_plugin.c: In function ‘uwsgi_python_resume’:
      plugins/python/python_plugin.c:1873:11: error: ‘PyThreadState’ {aka ‘struct _ts’} has no member named ‘c_recursion_remaining’; did you mean ‘py_recursion_remaining’?
       1873 |   tstate->c_recursion_remaining = up.current_c_recursion_remaining[wsgi_req->async_id];
            |           ^~~~~~~~~~~~~~~~~~~~~
            |           py_recursion_remaining
      plugins/python/python_plugin.c:1890:11: error: ‘PyThreadState’ {aka ‘struct _ts’} has no member named ‘c_recursion_remaining’; did you mean ‘py_recursion_remaining’?
       1890 |   tstate->c_recursion_remaining = up.current_main_c_recursion_remaining;
            |           ^~~~~~~~~~~~~~~~~~~~~
            |           py_recursion_remaining
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for uWSGI
  Running setup.py clean for uWSGI
Successfully built kinto
Failed to build uWSGI

Notice:  A new release of pip is available: 25.0.1 -> 25.1
Notice:  To update, run: /home/benchmarking/actions-runner/_work/benchmarking/benchmarking/venv/cpython3.14-ee88948380c0-compat-64aaec271e6b-bm-kinto/bin/python -m pip install --upgrade pip
ERROR: Failed to build installable wheels for some pyproject.toml based projects (uWSGI)
Command failed with exit code 1
(benchmark will be skipped)

@iritkatriel
Copy link
Member

I'm not sure what they're trying to do here, maybe there's an API we can give them? https://github.com/unbit/uwsgi/blob/ae7ecb01e898631f2d32ab957f839f4a465447d5/plugins/python/python_plugin.c#L1169

vstinner added a commit to vstinner/uwsgi that referenced this pull request May 11, 2025
@vstinner
Port to Python 3.14 beta 1
f65c2da 
The PyThreadState.c_recursion_remaining member has been removed in
Python 3.14 beta 1:
python/cpython#133080
vstinner added a commit to vstinner/uwsgi that referenced this pull request May 11, 2025
@vstinner
plugins/python: Port to Python 3.14 beta 1
03f8786 
The PyThreadState.c_recursion_remaining member has been removed in
Python 3.14 beta 1:
python/cpython#133080
@vstinner vstinner mentioned this pull request May 11, 2025
Merged
@vstinner
Copy link
Member

I created a PR for uWSGI: unbit/uwsgi#2724.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@corona10 corona10 corona10 approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@encukou @bedevere-bot @iritkatriel @hugovk @vstinner @corona10
0