From d31e50ec1976e0096fa0cd3d7fa3b6cf916f6742 Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Mon, 24 Mar 2025 14:02:44 +0100 Subject: [PATCH 1/2] gh-111178: Fix function signature for test_threading --- Modules/_threadmodule.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Modules/_threadmodule.c b/Modules/_threadmodule.c index bcac2b48f18457..61aa6b4b5e0d1b 100644 --- a/Modules/_threadmodule.c +++ b/Modules/_threadmodule.c @@ -384,8 +384,9 @@ thread_run(void *boot_raw) } static int -force_done(ThreadHandle *handle) +force_done(void *arg) { + ThreadHandle *handle = (ThreadHandle *)arg; assert(get_thread_handle_state(handle) == THREAD_HANDLE_STARTING); _PyEvent_Notify(&handle->thread_is_exiting); set_thread_handle_state(handle, THREAD_HANDLE_DONE); From 903082ccd43f201f19c18534dbf1b2cbabbab5c0 Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Mon, 24 Mar 2025 14:31:18 +0100 Subject: [PATCH 2/2] Remove now useless cast --- Modules/_threadmodule.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Modules/_threadmodule.c b/Modules/_threadmodule.c index 61aa6b4b5e0d1b..f4c98ca39f6ee6 100644 --- a/Modules/_threadmodule.c +++ b/Modules/_threadmodule.c @@ -459,7 +459,7 @@ ThreadHandle_start(ThreadHandle *self, PyObject *func, PyObject *args, return 0; start_failed: - _PyOnceFlag_CallOnce(&self->once, (_Py_once_fn_t *)force_done, self); + _PyOnceFlag_CallOnce(&self->once, force_done, self); return -1; }