8000 gh-131441: Add a set of asserts to test.test_capi.test_list by nybblista · Pull Request #131442 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

gh-131441: Add a set of asserts to test.test_capi.test_list #131442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

nybblista
Copy link
Contributor
@nybblista nybblista commented Mar 19, 2025
  1. Assert 0-sized list for PyList_Size().
  2. Assert 0-sized list for PyList_GET_SIZE().
  3. Assert reverse of reverse for PyList_Reverse().
  4. Assert a list that contains one empty-list element for PyList_AsTuple().

1. Assert 0-sized list for PyList_Size()
2. Assert 0-sized list for PyList_GET_SIZE()
3. Assert reverse of reverse for PyList_Reverse()
4. Assert a list that contains one empty-list element for PyList_AsTuple()
@nybblista
Copy link
Contributor Author

@iritkatriel

@iritkatriel iritkatriel merged commit 2433cc7 into python:main Mar 20, 2025
48 checks passed
@vstinner
Copy link
Member

Nice enhancement.

@nybblista nybblista deleted the test-capi-list branch March 20, 2025 13:26
@nybblista
Copy link
Contributor Author

@sobolevn Needs backport?

@sobolevn sobolevn added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Mar 20, 2025
@miss-islington-app
Copy link

Thanks @nybblista for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Thanks @nybblista for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 20, 2025
…thonGH-131442)

(cherry picked from commit 2433cc7)

Co-authored-by: Nybblista <170842536+nybblista@users.noreply.github.com>
@bedevere-app
Copy link
bedevere-app bot commented Mar 20, 2025

GH-131523 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 20, 2025
@miss-islington-app
Copy link

Sorry, @nybblista and @iritkatriel, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 2433cc79d79d9c1db8e53d4b9bde26e9a47fb0b9 3.12

@sobolevn
Copy link
Member

Yes, because we usually backport test changes

sobolevn pushed a commit that referenced this pull request Mar 20, 2025
…H-131442) (#131523)

gh-131441: Add a set of asserts to test.test_capi.test_list (GH-131442)
(cherry picked from commit 2433cc7)

Co-authored-by: Nybblista <170842536+nybblista@users.noreply.github.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable Clang Installed 3.13 (tier-2) has failed when building commit d256cfe.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1387/builds/593) and take a look at the build logs.
  4. Check if the failure is related to this commit (d256cfe) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1387/builds/593

Failed tests:

  • test_perf_profiler

Failed subtests:

  • test_python_calls_appear_in_the_stack_if_perf_activated - test.test_perf_profiler.TestPerfProfilerWithDwarf.test_python_calls_appear_in_the_stack_if_perf_activated

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/lib/python3.13/test/test_perf_profiler.py", line 356, in test_python_calls_appear_in_the_stack_if_perf_activated
    self.assertIn(f"py::foo:{script}", stdout)
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'py::foo:/tmp/test_python_a5jkeh2k/tmp90cyqtg7/perftest.py' not found in 'python3.13 1209344 1364464.030989:          1 cycles:Pu: \n\tffffc95efcdffc78 [unknown] ([unknown])\n\tffffc95efce0049c [unknown] ([unknown])\n\tffffc95efb9a15e4 [unknown] ([unknown])\n\t    ffffab384ac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython3.13 1209344 1364464.031111:          1 cycles:Pu: \n\t    ffffab384ac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython3.13 1209344 1364464.031132:        174 cycles:Pu: \n\t    ffffab38056c _dl_start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffab384ad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython3.13 1209344 1364464.032307:       1929 cycles:Pu: \n\t    ffffab371d7c do_lookup_x+0xfc (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffab372833 _dl_lookup_symbol_x+0x113 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffab3766ff <invalid>+0x79f (inlined)\n\t    ffffab3766ff <invalid>+0x79f (inlined)\n\t    ffffab3766ff <invalid>+0x79f (inlined)\n\t    ffffab3766ff _dl_relocate_object+0x79f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffab3823d3 dl_main+0x15d3 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffab37f5ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffab380b17 _dl_start_final+0x5ab (inlined)\n\t    ffffab380b17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffab384ad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython3.13 1209344 1364464.032483:     101659 cycles:Pu: \n\t    ffffab371fa8 do_lookup_x+0x328 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffab372833 _dl_lookup_symbol_x+0x113 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffffab3766ff <invalid>+0x79f (inlined)\n\t    ffffab3766ff <invalid>+0x79f (inlined)\n\t    ffffab3766ff <invalid>+0x79f (inlined)\n\t    ffffab3766ff _dl_relocate_object+0x79f (/usr/lib/ld-linux-aarch64.so.1)\n\t 
in/python3.13)\n\t          4f4adf type_add_getset+0xad3 (inlined)\n\t          4f4adf type_ready_fill_dict+0xad3 (inlined)\n\t          4f4adf type_ready+0xad3 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          4f6243 init_static_type+0x187 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          4c4683 _PyTypes_InitTypes+0x2f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          5f275b pycore_init_types+0x23 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          5f25c7 pycore_interp_init+0x12f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          5f242b pyinit_config+0x237 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          5ef983 pyinit_core+0x2af (inlined)\n\t          5ef983 Py_InitializeFromConfig+0x2af (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          61da9b pymain_init+0x10b (inlined)\n\t          61da9b pymain_main+0x10b (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          61db4f Py_BytesMain+0x27 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t    ffffab11625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffffab11633b __libc_start_main@GLIBC_2.17+0x9b (inlined)\n\t          41daef _start+0x2f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\npython3.13 1209344 1364464.043168:    9026453 cycles:Pu: \n\t          4a8a3c compare_unicode_unicode+0xd4 (inlined)\n\t          4a8a3c do_lookup+0xd4 (inlined)\n\t          4a8a3c unicodekeys_lookup_unicode+0xd4 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          4a908f _Py_dict_lookup+0x4cb (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          4ad0e7 dict_setdefault_ref_lock_held+0x207 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          529153 intern_common+0x1af (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          5095df _PyUnicode_InternImmortal+0x1b (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          4ae59f PyDict_SetItemString+0x43 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          6073c7 _PySys_UpdateConfig+0x9b (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          5f2d47 interpreter_update_config+0x26b (inlined)\n\t          5f2d47 init_interp_main+0x26b (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          5efa6f pyinit_main+0x39b (inlined)\n\t          5efa6f Py_InitializeFromConfig+0x39b (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          61da9b pymain_init+0x10b (inlined)\n\t          61da9b pymain_main+0x10b (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          61db4f Py_BytesMain+0x27 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t    ffffab11625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffffab11633b __libc_start_main@GLIBC_2.17+0x9b (inlined)\n\t          41daef _start+0x2f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/b


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/lib/python3.13/test/test_perf_profiler.py", line 356, in test_python_calls_appear_in_the_stack_if_perf_activated
    self.assertIn(f"py::foo:{script}", stdout)
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'py::foo:/tmp/test_python_r1wf81sg/tmp9_kxfmk7/perftest.py' not found in 'python3.13 1221673 1364540.104718:          1 cycles:Pu: \n\tffffc95efcdffc78 [unknown] ([unknown])\n\tffffc95efce0049c [unknown] ([unknown])\n\tffffc95efb9a15e4 [unknown] ([unknown])\n\t    ffff89a84ac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython3.13 1221673 1364540.104775:          1 cycles:Pu: \n\t    ffff89a84ac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython3.13 1221673 1364540.105124:          1 cycles:Pu: \n\t    ffff89a73710 _dl_sysdep_read_whole_file+0x50 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff89a7ba0f _dl_load_cache_lookup+0x127 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff89a712c3 _dl_map_object+0x377 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff89a6c5bf openaux+0x3f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff89a6b303 _dl_catch_exception+0x63 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff89a6cb33 _dl_map_object_deps+0x553 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff89a8219f dl_main+0x139f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff89a7f5ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff89a80b17 _dl_start_final+0x5ab (inlined)\n\t    ffff89a80b17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff89a84ad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython3.13 1221673 1364540.105152:        402 cycles:Pu: \n\t    ffff89a86600 mmap64+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff89a7375b _dl_sysdep_read_whole_file+0x9b (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff89a7ba0f _dl_load_cache_lookup+0x127 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff89a712c3 _dl_map_object+0x377 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff89a6c5bf openaux+0x3f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff89a6b303 _dl_catch_exception+0x63 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff89a6cb33 _dl_map_object_deps+0x553 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff89a8219f dl_main+0x139f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff89a7f5ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff89a80b17 _dl_start_final+0x5ab (inlined)\n\t    ffff89a80b17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff89a84ad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython3.13 1221673 1364540.106129:       1805 cycles:Pu: \n\t    ffff89a72774 <invalid>+0x54 (inlined)\n\t    ffff89a72774 _dl_lookup_symbol_x+0x54 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff89a77a5b _dl_fixup+0xfb (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff89a79ef7 _dl_runtime_resolve+0x47 (/usr/lib/ld-linux-aarch64.so.1)\n\t          4d85b7 _mi_prim_random_buf+0xbb (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          4d4743 mi_random_init_ex+0x2f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t  
ildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t    ffff898163b7 call_init+0x117 (inlined)\n\t    ffff898163b7 __libc_start_main@GLIBC_2.17+0x117 (inlined)\n\t          41daef _start+0x2f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\npython3.13 1221673 1364540.107461:     159412 cycles:Pu: \n\t          5375f8 intern_static+0x644 (inlined)\n\t          5375f8 _PyUnicode_InternStatic+0x644 (inlined)\n\t          5375f8 _PyUnicode_InitStaticStrings+0x644 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          528cc3 init_global_interned_strings+0x87 (inlined)\n\t          528cc3 _PyUnicode_InitGlobalObjects+0x87 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          5f24cf pycore_init_global_objects+0x37 (inlined)\n\t          5f24cf pycore_interp_init+0x37 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          5f242b pyinit_config+0x237 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          5ef983 pyinit_core+0x2af (inlined)\n\t          5ef983 Py_InitializeFromConfig+0x2af (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          61da9b pymain_init+0x10b (inlined)\n\t          61da9b pymain_main+0x10b (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          61db4f Py_BytesMain+0x27 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t    ffff8981625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffff8981633b __libc_start_main@GLIBC_2.17+0x9b (inlined)\n\t          41daef _start+0x2f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\npython3.13 1221673 1364540.108740:    1505604 cycles:Pu: \n\t          4f44ac add_operators+0x4a0 (inlined)\n\t          4f44ac type_ready_fill_dict+0x4a0 (inlined)\n\t          4f44ac type_ready+0x4a0 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          4f6243 init_static_type+0x187 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          4c4683 _PyTypes_InitTypes+0x2f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          5f275b pycore_init_types+0x23 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          5f25c7 pycore_interp_init+0x12f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          5f242b pyinit_config+0x237 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          5ef983 pyinit_core+0x2af (inlined)\n\t          5ef983 Py_InitializeFromConfig+0x2af (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          61da9b pymain_init+0x10b (inlined)\n\t          61da9b pymain_main+0x10b (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t          61db4f Py_BytesMain+0x27 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\t    ffff8981625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffff8981633b __libc_start_main@GLIBC_2.17+0x9b (inlined)\n\t          41daef _start+0x2f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang-installed/build/target/bin/python3.13)\n\npython3.13 1221673 1364540.110945:    3406939 cycles:Pu: \n\t          60c874 PyThread_GetInfo+0x0 (/home/buildbot/buildarea/3.13.cstratak-

@sobolevn
Copy link
Member

@nybblista can you please create a manual 3.12 backport?

@nybblista
Copy link
Contributor Author
nybblista commented Mar 21, 2025

@sobolevn GH-131533
Sorry, I forgot to add [3.12], and thank you for @skirpichev

@bedevere-app
Copy link
bedevere-app bot commented Mar 21, 2025

GH-131533 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Mar 21, 2025
sobolevn pushed a commit that referenced this pull request Mar 21, 2025
…131442) (#131533)

gh-131441: Add a set of asserts to test.test_capi.test_list (#131442)

(cherry picked from commit 2433cc7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0