8000 gh-112020: Rework socketserver examples to be correct by gpshead · Pull Request #129741 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

8000 gh-112020: Rework socketserver examples to be correct #129741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

gpshead
Copy link
Member
@gpshead gpshead commented Feb 6, 2025

Outdated code updated, the BaseRequestHandler example is now much more illustrative instead of the bad idea of a single recv() call for TCP.

tested, they now work.

Fixes: #112020
Closes: #112020


📚 Documentation preview 📚: https://cpython-previews--129741.org.readthedocs.build/

Outdated code updated, the BaseRequestHandler example is now much more
illustrative instead of the bad idea of a single recv() call for TCP.

tested, they now work.
@gpshead gpshead added docs Documentation in the Doc dir needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Feb 6, 2025
@gpshead gpshead self-assigned this Feb 6, 2025
@gpshead gpshead merged commit 78377c7 into python:main Feb 6, 2025
35 checks passed
@miss-islington-app
Copy link

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@gpshead gpshead deleted the docs/socketserver-example-improvements branch February 6, 2025 17:42
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 6, 2025
…-129741)

pythongh-112020: Rework socketserver examples to be correct.

Outdated code updated, the BaseRequestHandler example is now much more
illustrative instead of the bad idea of a single recv() call for TCP.

tested, they now work.
(cherry picked from commit 78377c7)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-app
Copy link
bedevere-app bot commented Feb 6, 2025

GH-129743 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 6, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 6, 2025
…-129741)

pythongh-112020: Rework socketserver examples to be correct.

Outdated code updated, the BaseRequestHandler example is now much more
illustrative instead of the bad idea of a single recv() call for TCP.

tested, they now work.
(cherry picked from commit 78377c7)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-app
Copy link
bedevere-app bot commented Feb 6, 2025

GH-129744 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 6, 2025
@miss-islington-app
Copy link

Sorry @gpshead, I had trouble completing the backport.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Please backport backport using cherry_picker on the command line.

cherry_picker 78377c788e02e91bf43d290d69317198a2e563fd 3.12

gpshead added a commit that referenced this pull request Feb 6, 2025
…) (#129743)

gh-112020: Rework socketserver examples to be correct.

Outdated code updated, the BaseRequestHandler example is now much more
illustrative instead of the bad idea of a single recv() call for TCP.

tested, they now work.
(cherry picked from commit 78377c7)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
gpshead added a commit that referenced this pull request Feb 6, 2025
…) (#129744)

gh-112020: Rework socketserver examples to be correct.

Outdated code updated, the BaseRequestHandler example is now much more
illustrative instead of the bad idea of a single recv() call for TCP.

tested, they now work.
(cherry picked from commit 78377c7)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
…29741)

pythongh-112020: Rework socketserver examples to be correct.

Outdated code updated, the BaseRequestHandler example is now much more
illustrative instead of the bad idea of a single recv() call for TCP.

tested, they now work.
cmaloney pushed a commit to cmaloney/cpython that referenced this pull request Feb 8, 2025
…29741)

pythongh-112020: Rework socketserver examples to be correct.

Outdated code updated, the BaseRequestHandler example is now much more
illustrative instead of the bad idea of a single recv() call for TCP.

tested, they now work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

socketserver's TCPServer documentation only presents case of single request per connection
1 participant
0