10000 gh-129185: Fix crash during interpreter finalization in PyTraceMalloc_Untrack by rostan-t · Pull Request #129188 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-129185: Fix crash during interpreter finalization in PyTraceMalloc_Untrack #129188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

gh-129185: Fix crash during interpreter finalization in PyTraceMalloc_Untrack #129188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Finalize imports before tracemalloc 
Signed-off-by: Rostan Tabet <rtabet@nvidia.com>
  • Loading branch information
@rostan-t
rostan-t committed Jan 22, 2025
commit 3245947faef497c437bab2557a73a5611eb3ada1
8 changes: 4 additions & 4 deletions Python/pylifecycle.c
View file
Open in desktop
Original file line number Diff line number Diff line change
AE34 Expand Up @@ -2127,15 +2127,15 @@ _Py_Finalize(_PyRuntimeState *runtime)
_PyGC_CollectIfEnabled();
#endif

/* Disable tracemalloc after all Python objects have been destroyed,
so it is possible to use tracemalloc in objects destructor. */
_PyTraceMalloc_Fini();

/* Finalize any remaining import state */
// XXX Move these up to where finalize_modules() is currently.
_PyImport_FiniCore(tstate->interp);
_PyImport_Fini();

/* Disable tracemalloc after all Python objects have been destroyed,
so it is possible to use tracemalloc in objects destructor. */
_PyTraceMalloc_Fini();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that this fix is enough. Some objects can be deleted later, in finalize_interp_clear(). So I wrote a different fix to restore the old behavior: PR gh-129191.


/* unload faulthandler module */
_PyFaulthandler_Fini();

Expand Down
Loading
0