8000 [3.7] bpo-32217: Correct usage of ABI tags in freeze. (GH-4719) by miss-islington · Pull Request #12516 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.7] bpo-32217: Correct usage of ABI tags in freeze. (GH-4719) #12516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2019
Merged

[3.7] bpo-32217: Correct usage of ABI tags in freeze. (GH-4719) #12516

merged 1 commit into from
Mar 23, 2019

Conversation

miss-islington
Copy link
Contributor
@miss-islington miss-islington commented Mar 23, 2019 •
edited by bedevere-bot
Loading

Check for sys.abiflags before using since not all platforms have it defined.
(cherry picked from commit a7987e7)

Co-authored-by: AraHaan 15173749+AraHaan@users.noreply.github.com

https://bugs.python.org/issue32217

@AraHaan @miss-islington
bpo-32217: Correct usage of ABI tags in freeze. (pythonGH-4719)
977e128 
Check for sys.abiflags before using since not all platforms have it defined.
(cherry picked from commit a7987e7)

Co-authored-by: AraHaan <15173749+AraHaan@users.noreply.github.com>
@bedevere-bot bedevere-bot mentioned this pull request Mar 23, 2019
Merged
csabella
csabella approved these changes Mar 23, 2019
View reviewed changes
Copy link
Contributor
@csabella csabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🤖

@miss-islington
Copy link
Contributor Author

@AraHaan and @csabella: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit d93de02 into python:3.7 Mar 23, 2019
@miss-islington miss-islington deleted the backport-a7987e7-3.7 branch March 23, 2019 16:47
@miss-islington
Copy link
Contributor Author

@AraHaan and @csabella: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csabella csabella csabella approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miss-islington @csabella @the-knights-who-say-ni @bedevere-bot @AraHaan
0