gh-124628: Pyrepl inputs on Windows shouldn't always be blocking reads #124629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 26, 2024
…g reads (pythonGH-124629) (cherry picked from commit 83e5dc0) Co-authored-by: Dino Viehland <dinoviehland@meta.com>
|
GH-124638 is a backport of this pull request to the 3.13 branch. |
Yhg1s
pushed a commit
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReadConsoleInputis documented to always return at least 1 input. This causes a couple of hangs in the Windows version of pyrepl:block=Falsewe also still block. We can use the API to check if there are any inputs available, and if not, then just not block.