8000 gh-124120: Document `Annotated.__origin__` by sobolevn · Pull Request #124125 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-124120: Document Annotated.__origin__ #124125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
8000
Merged
merged 6 commits into from
Sep 24, 2024
Merged

gh-124120: Document Annotated.__origin__ #124125

merged 6 commits into from
Sep 24, 2024

Conversation

sobolevn
Copy link
Member
@sobolevn sobolevn commented Sep 16, 2024 •
edited by github-actions bot
Loading

@sobolevn sobolevn added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixe 8000 s labels Sep 16, 2024
@sobolevn sobolevn requested a review from ncoghlan September 16, 2024 13:37
@bedevere-app bedevere-app bot mentioned this pull request Sep 16, 2024
Closed
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Sep 16, 2024
@sobolevn sobolevn changed the title gh-124120: Document use of get_origin to access Annotated origin gh-124120: Document Annotated.__origin__ Sep 16, 2024
@sobolevn @brianschubert
Update Doc/library/typing.rst
a9a3f74 
Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
AlexWaygood
AlexWaygood reviewed Sep 16, 2024
View reviewed changes
sobolevn and others added 2 commits September 16, 2024 19:20
@sobolevn @AlexWaygood
Apply suggestions from code review
e8de2a5 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@sobolevn
Fix tests
8994ed4
JelleZijlstra
JelleZijlstra reviewed Sep 20, 2024
View reviewed changes
Copy link
Member
@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is fine but I don't like this long bulleted list of individual issues. We should rewrite it to a more organized form.

@sobolevn
Copy link
Member Author

We should rewrite it to a more organized form.

Ok, I will open an new issue for that!

This change is fine

So, I will merge it later today if no one else has any feedback.
Thank you!

@sobolevn sobolevn mentioned this pull request Sep 20, 2024
Closed
@sobolevn sobolevn merged commit faef3fa into python:main Sep 24, 2024
23 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 24, 2024
@sobolevn @brianschubert
@AlexWaygood @miss-islington
pythongh-124120: Document Annotated.__origin__ (pythonGH-124125)
270c80f 
(cherry picked from commit faef3fa)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-app
Copy link
bedevere-app bot commented Sep 24, 2024

GH-124416 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 24, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 24, 2024
@sobolevn @brianschubert
@AlexWaygood @miss-islington
pythongh-124120: Document Annotated.__origin__ (pythonGH-124125)
bacb190 
(cherry picked from commit faef3fa)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-app
Copy link
bedevere-app bot commented Sep 24, 2024

GH-124417 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Sep 24, 2024
sobolevn added a commit that referenced this pull request Sep 24, 2024
@miss-islington @sobolevn
@brianschubert @AlexWaygood
[3.12] gh-124120: Document Annotated.__origin__ (GH-124125) (#124417)
0c36c37 
gh-124120: Document `Annotated.__origin__` (GH-124125)
(cherry picked from commit faef3fa)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Yhg1s pushed a commit that referenced this pull request Sep 24, 2024
@miss-islington @sobolevn
@brianschubert @AlexWaygood
[3.13] gh-124120: Document Annotated.__origin__ (GH-124125) (#124416)
8c0c344 
gh-124120: Document `Annotated.__origin__` (GH-124125)
(cherry picked from commit faef3fa)

Co-authored-by: sobolevn <mail@sobolevn.me>
Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@brianschubert brianschubert brianschubert left review comments

@AlexWaygood AlexWaygood AlexWaygood left review comments

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sobolevn @JelleZijlstra @brianschubert @AlexWaygood
0