10000 bpo-31062: Allow socket.makefile to handle line buffering properly by vxgmichel · Pull Request #12370 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-31062: Allow socket.makefile to handle line buffering properly #12370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bpo-31062: Allow socket.makefile to handle line buffering properly #12370

wants to merge 1 commit into from

Conversation

vxgmichel
Copy link
Contributor
@vxgmichel vxgmichel commented Mar 16, 2019 •
edited by bedevere-bot
Loading

Line buffering is enabled by using the argument buffering=1 as defined in io.open.

I did not update the docs for socket.makefile since it already mentions the arguments being interpreted the same way as open:

Return a file object associated with the socket. The exact returned type depends on the arguments given to makefile(). These arguments are interpreted the same way as by the built-in open() function, except the only supported mode values are 'r' (default), 'w' and 'b'.

https://bugs.python.org/issue31062

ZackerySpytz
ZackerySpytz reviewed Apr 22, 2019
View reviewed changes
@vxgmichel
bpo-31062: Allow socket.makefile to handle line buffering properly
2eaecd5 
Line buffering is enabled by using the argument `buffering=1` as
defined in `io.open`.
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jun 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZackerySpytz ZackerySpytz ZackerySpytz left review comments

< 563B /form>
Assignees
No one assigned
Labels
awaiting review stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vxgmichel @ZackerySpytz @the-knights-who-say-ni @ezio-melotti @bedevere-bot
0