gh-120782: Update internal type cache when reloading datetime #120829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumaraditya303
approved these changes
Jun 21, 2024
| _datetime.time.max > _datetime.time.min | ||
| _datetime.datetime.max > _datetime.datetime.min | ||
| _datetime.timedelta.max > _datetime.timedelta.min | ||
| isinstance(_datetime.timezone.min, _datetime.tzinfo) |
There was a problem hiding this comment.
assert isinstance(_datetime.timezone.min, _datetime.tzinfo)
~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError
assert not isinstance(_datetime.timezone.min, _datetime.tzinfo)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError
Both fail, so this checks if it crashes or not. I agree this is not a good example.
There was a problem hiding this comment.
Given that the code looks a bit unusual, it would be worth adding a brief comment explaining that.
(Sorry I didn't notice this during my earlier review. Good catch, @JelleZijlstra.)
There was a problem hiding this comment.
Wouldn't it make sense to have these asserts actually check that the values are of the type they should be? The bug manifested itself as these values appearing to be objects of various random types.
There was a problem hiding this comment.
You could also assert that timezone.__dict__["min"] is timezone.min.
|
Thanks. I'll make a backport PR to 3.13 manually with an assertion to the test case. |
|
GH-120855 is a backport of this pull request to the 3.13 branch. |
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
kumaraditya303
pushed a commit
that referenced
this pull request
Jul 3, 2024
…H-120829) (#120855) * [3.13] gh-120782: Update internal type cache when reloading datetime When reloading _datetime module, the single-phase version did not invoke the PyInit__datetime function, whereas the current multi-phase version updates the static types through the module init. The outdated static type cache in the interpreter state needs to be invalidated at the end of reloading the multi-phase module.
|
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reloading
_datetimemodule, the single-phase version did not invoke thePyInit__datetimefunction, whereas the current multi-phase version updates the static types through the module init. The outdated static type cache in the interpreter state needs to be invalidated at the end of reloading the multi-phase module.test_datetimefails with a--foreverargument #120782