8000 GH-120804: Remove `get_child_watcher` and `set_child_watcher` from asyncio by kumaraditya303 · Pull Request #120818 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

GH-120804: Remove get_child_watcher and set_child_watcher from asyncio #120818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 23, 2024
Merged

GH-120804: Remove get_child_watcher and set_child_watcher from asyncio #120818

merged 3 commits into from
Jun 23, 2024

Conversation

kumaraditya303
Copy link
Contributor
@kumaraditya303 kumaraditya303 commented Jun 21, 2024 •
edited by bedevere-app bot
Loading

This PR removes get_child_watcher and set_child_watcher from asyncio. At some place currently we directly write to policy._watcher as there are no apis to do that for testing. This is temporary and will change in subsequent PRs when subprocesses will be rewritten to not use child watchers at all and then this "hack" will become unnecessary and be removed.

@bedevere-app bedevere-app bot mentioned this pull request Jun 21, 2024
Closed
@kumaraditya303 kumaraditya303 merged commit 96ead91 into python:main Jun 23, 2024
30 of 31 checks passed
@kumaraditya303 kumaraditya303 deleted the watcher branch June 23, 2024 04:23
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu NoGIL Refleaks 3.x has failed when building commit 96ead91.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1226/builds/2089) and take a look at the build logs.
  4. Check if the failure is related to this commit (96ead91) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1226/builds/2089

Failed tests:

  • test_free_threading

Summary of the results of the build (if available):

==

Click to see traceback logs 
remote: Enumerating objects: 12, done.        
remote: Counting objects:   8% (1/12)        
remote: Counting objects:  16% (2/12)        
remote: Counting objects:  25% (3/12)        
remote: Counting objects:  33% (4/12)        
remote: Counting objects:  41% (5/12)        
remote: Counting objects:  50% (6/12)        
remote: Counting objects:  58% (7/12)        
remote: Counting objects:  66% (8/12)        
remote: Counting objects:  75% (9/12)        
remote: Counting objects:  83% (10/12)        
remote: Counting objects:  91% (11/12)        
remote: Counting objects: 100% (12/12)        
remote: Counting objects: 100% (12/12), done.        
remote: Compressing objects:  11% (1/9)        
remote: Compressing objects:  22% (2/9)        
remote: Compressing objects:  33% (3/9)        
remote: Compressing objects:  44% (4/9)        
remote: Compressing objects:  55% (5/9)        
remote: Compressing objects:  66% (6/9)        
remote: Compressing objects:  77% (7/9)        
remote: Compressing objects:  88% (8/9)        
remote: Compressing objects: 100% (9/9)        
remote: Compressing objects: 100% (9/9), done.        
remote: Total 12 (delta 3), reused 4 (delta 3), pack-reused 0        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to '96ead91f0f0db59a942b8b34da9cc980c05588a2'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 96ead91f0f GH-120804: Remove `get_child_watcher` and `set_child_watcher` from asyncio (#120818)
Switched to and reset branch 'main'

configure: WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)

make: *** [Makefile:2252: buildbottest] Error 2

mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@kumaraditya303 @mrahtz
pythonGH-120804: Remove get_child_watcher and set_child_watcher f…
b08b277 
…rom asyncio (python#120818)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@kumaraditya303 @noahbkim
pythonGH-120804: Remove get_child_watcher and set_child_watcher f…
95b1e1f 
…rom asyncio (python#120818)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@kumaraditya303 @estyxx
pythonGH-120804: Remove get_child_watcher and set_child_watcher f…
9f8db2f 
…rom asyncio (python#120818)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
skip news topic-asyncio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kumaraditya303 @bedevere-bot
0