gh-119690: Adds Unicode support for named pipes in _winapi #119717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eryksun
reviewed
May 29, 2024
| def test_winapi_createnamedpipe(self): | ||
| winapi = import_helper.import_module("_winapi") | ||
|
|
||
| pipe_name = r"\\.\pipe\LOCAL\test_winapi_createnamed_pipe" |
There was a problem hiding this comment.
Can the pipe name contain non-ASCII characters?
There was a problem hiding this comment.
It can, but the problem being checked here was due to misrepresenting char * as wchar_t *, and so ASCII is sufficient to turn into corruption when you s.encode('ascii').decode('utf-16-le').
eryksun
reviewed
May 29, 2024
|
Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 29, 2024
…honGH-119717) (cherry picked from commit 78d697b) Co-authored-by: Steve Dower <steve.dower@python.org>
|
Sorry, @zooba, I could not cleanly backport this to |
|
GH-119732 is a backport of this pull request to the 3.13 branch. |
|
GH-119733 is a backport of this pull request to the 3.12 branch. |
zooba
added a commit
to zooba/cpython
that referenced
this pull request
May 29, 2024
zooba
added a commit
that referenced
this pull request
May 30, 2024
Also backports a minor improvement to test_audit.
zooba
added a commit
that referenced
this pull request
May 31, 2024
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will need backporting further, but it's only getting to 3.12 in this form. I'll do the 3.11 and earlier ports separately.