gh-116515: Clear thread-local state before tstate_delete_common() #116517
8000Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves current_fast_clear() up so that the current thread state is NULL while running tstate_delete_common().
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit 4f541ef 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
ericsnowcurrently
approved these changes
Mar 8, 2024
|
!buildbot debian root |
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit 4f541ef 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
…() (python#116517) This moves `current_fast_clear()` up so that the current thread state is `NULL` while running `tstate_delete_common()`. This doesn't fix any bugs, but it means that we are more consistent that `_PyThreadState_GET() != NULL` means that the thread is "attached".
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…() (python#116517) This moves `current_fast_clear()` up so that the current thread state is `NULL` while running `tstate_delete_common()`. This doesn't fix any bugs, but it means that we are more consistent that `_PyThreadState_GET() != NULL` means that the thread is "attached".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves
current_fast_clear()up so that the current thread state isNULLwhile runningtstate_delete_common().This doesn't fix any bugs, but it means that we are more consistent that
_PyThreadState_GET() != NULLmeans that the thread is "attached".