8000 gh-114058: More robust method handling in redundancy eliminator by Fidget-Spinner · Pull Request #115779 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-114058: More robust method handling in redundancy eliminator #115779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 23, 2024
Merged

gh-114058: More robust method handling in redundancy eliminator #115779

merged 3 commits into from
Feb 23, 2024

Conversation

Fidget-Spinner
Copy link
Member
@Fidget-Spinner Fidget-Spinner commented Feb 21, 2024 •
edited by bedevere-app bot
Loading

Method handling was actually previously buggy.

@bedevere-app bedevere-app bot mentioned this pull request Feb 21, 2024
Closed
gvanrossum
gvanrossum reviewed Feb 21, 2024
View reviewed changes
Copy link
Member
@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain what was buggy in the previous version? Neither the issue you linked to nor the diff helps me understand the problem you're addressing here. Was it a correctness bug or was it simply not optimizing as much as it could around the four newly special-cased opcodes?

@Fidget-Spinner
Copy link
Member Author

Can you explain what was buggy in the previous version? Neither the issue you linked to nor the diff helps me understand the problem you're addressing here. Was it a correctness bug or was it simply not optimizing as much as it could around the four newly special-cased opcodes?

The bug is that we did not mark notnull as KNOWN. I added the other method opcodes to test out the frame locals copying.

@Fidget-Spinner Fidget-Spinner merged commit a33ffe4 into python:main Feb 23, 2024
@Fidget-Spinner Fidget-Spinner deleted the buggy_methods branch February 23, 2024 07:42
@markshannon
Copy link
Member

I think this approach is flawed.
We only push NULL to the stack in a few places. It would be safer to explicitly mark those places as pushing NULL and make the default "not NULL".

markshannon
markshannon reviewed Feb 23, 2024
View reviewed changes
markshannon
markshannon reviewed Feb 23, 2024
View reviewed changes
markshannon
markshannon reviewed 8000 Feb 23, 2024
View reviewed changes
@Fidget-Spinner Fidget-Spinner mentioned this pull request Feb 23, 2024
Merged
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@Fidget-Spinner @woodruffw
pythongh-114058: More robust method handling in redundancy eliminator (…
ec80696 
…pythonGH-115779)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@Fidget-Spinner @diegorusso
pythongh-114058: More robust method handling in redundancy eliminator (…
296142a 
…pythonGH-115779)
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull request Jan 22, 2025
@Fidget-Spinner @LukasWoodtli
pythongh-114058: More robust method handling in redundancy eliminator (…
efd2e64 
…pythonGH-115779)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon markshannon left review comments

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fidget-Spinner @markshannon @gvanrossum
0